Changeset 0531801

Timestamp:

May 13, 2019 2:44:35 PM (2 years ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

4e267f6

Parents:

8840532

Message:

Console: Prevent editing a client while it's starting

File:

• apps/routerconsole/java/src/net/i2p/router/web/helpers/ConfigClientsHelper.java (modified) (2 diffs)

apps/routerconsole/java/src/net/i2p/router/web/helpers/ConfigClientsHelper.java

@@ -141 +141 @@
             boolean showStart;
             boolean showStop;
+            boolean showEdit;
             if (isConsole) {
                 showStart = false;
                 showStop = false;
+                showEdit = true;
             } else {
                 ClientApp clientApp = _context.routerAppManager().getClientApp(ca.className, LoadClientAppsJob.parseArgs(ca.args));
                 showStart = clientApp == null;
                 showStop = clientApp != null && clientApp.getState() == ClientAppState.RUNNING;
+                showEdit = !showStop && (clientApp == null || clientApp.getState() != ClientAppState.STARTING);
             }
             String scur = Integer.toString(cur);
@@ -162 +165 @@
                        allowEdit && scur.equals(_edit),
                        // show edit button, show update button
-                       // Don't allow edit if it's running, or else we would lose the "handle" to the ClientApp to stop it.
-                       allowEdit && !showStop, false, 
+                       // Don't allow edit if it's running or starting, or else we would lose the "handle" to the ClientApp to stop it.
+                       allowEdit && showEdit,
+                       false, 
                        // show stop button
                        showStop,