Changeset 1c4b033

Timestamp:

Dec 9, 2011 11:01:19 PM (8 years ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

fc7d8f7

Parents:

50606a6

Message:

move error check to a better place

File:

• router/java/src/net/i2p/router/transport/udp/PacketBuilder.java (modified) (2 diffs)

router/java/src/net/i2p/router/transport/udp/PacketBuilder.java

@@ -239 +239 @@
             return null;
         }
-        if (dataSize == 0) {
-            // OK according to the protocol but if we send it, it's a bug
-            _log.error("Sending zero-size fragment " + fragment + " of " + state + " for " + peer);
-        }
+
         int currentMTU = peer.getMTU();
         int availableForAcks = currentMTU - MIN_DATA_PACKET_OVERHEAD - dataSize;
@@ -383 +380 @@
         //               + " of " + state.getMessageId());
         }
+        // put this after writeFragment() since dataSize will be zero for use-after-free
+        if (dataSize == 0) {
+            // OK according to the protocol but if we send it, it's a bug
+            _log.error("Sending zero-size fragment " + fragment + " of " + state + " for " + peer);
+        }
         off += dataSize;