Changeset 32e1c96

Timestamp:

Sep 22, 2016 5:10:50 PM (4 years ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

4ab727a

Parents:

fb323ce

Message:

EdDSA: throw IllegalStateException? instead of NPE if field not set

File:

• core/java/src/net/i2p/crypto/eddsa/math/bigint/BigIntegerLittleEndianEncoding.java (modified) (2 diffs)

core/java/src/net/i2p/crypto/eddsa/math/bigint/BigIntegerLittleEndianEncoding.java

@@ -30 +30 @@
      *
      *  @return array of length b/8
+     *  @throws IllegalStateException if field not set
      */
     public byte[] encode(BigInteger x) {
+        if (f == null)
+            throw new IllegalStateException("field not set");
         byte[] in = x.toByteArray();
         byte[] out = new byte[f.getb()/8];
@@ -43 +46 @@
     }
 
+    /**
+     *  Decode a FieldElement from its (b-1)-bit encoding.
+     *  The highest bit is masked out.
+     *
+     *  @param in the (b-1)-bit encoding of a FieldElement.
+     *  @return the FieldElement represented by 'val'.
+     *  @throws IllegalStateException if field not set
+     *  @throws IllegalArgumentException if encoding is invalid
+     */
     public FieldElement decode(byte[] in) {
+        if (f == null)
+            throw new IllegalStateException("field not set");
         if (in.length != f.getb()/8)
             throw new IllegalArgumentException("Not a valid encoding");