Changeset 39039b8

Timestamp:

Mar 10, 2018 5:19:38 PM (2 years ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

eb321445

Parents:

e7c2162

Message:

Console: Fix translated (es) plural
Warnings for special cases on /configtunnels

Location:

apps/routerconsole/java/src/net/i2p/router/web/helpers

Files:

• ConfigTunnelsHelper.java (modified) (2 diffs)
• NetDbRenderer.java (modified) (2 diffs)

apps/routerconsole/java/src/net/i2p/router/web/helpers/ConfigTunnelsHelper.java

@@ -7 +7 @@
 import net.i2p.data.Destination;
 import net.i2p.router.TunnelPoolSettings;
+import net.i2p.router.transport.TransportUtil;
 import net.i2p.router.web.HelperBase;
 
@@ -78 +79 @@
             in.getLength() + in.getLengthVariance() <= 0 ||
             out.getLength() <= 0 ||
-            out.getLength() + out.getLengthVariance() <= 0)
+            out.getLength() + out.getLengthVariance() <= 0) {
             buf.append("<tr><th colspan=\"3\"><font color=\"red\">" + _t("ANONYMITY WARNING - Settings include 0-hop tunnels.") + "</font></th></tr>");
-        else if (in.getLength() <= 1 ||
+            if (TransportUtil.getIPv6Config(_context, "SSU") == TransportUtil.IPv6Config.IPV6_ONLY) {
+                // rare, don't bother translating
+                buf.append("<tr><th colspan=\"3\"><font color=\"red\">WARNING - 0-hop tunnels not recommended for IPv6-only routers.</font></th></tr>");
+            }
+            if ((in.getLength() <= 0 || in.getLength() + in.getLengthVariance() <= 0) &&
+                _context.router().isHidden()) {
+                // rare, don't bother translating
+                buf.append("<tr><th colspan=\"3\"><font color=\"red\">WARNING - Inbound 0-hop tunnels not recommended for hidden routers.</font></th></tr>");
+            }
+        } else if (in.getLength() <= 1 ||
             in.getLength() + in.getLengthVariance() <= 1 ||
             out.getLength() <= 1 ||
-            out.getLength() + out.getLengthVariance() <= 1)
+            out.getLength() + out.getLengthVariance() <= 1) {
             buf.append("<tr><th colspan=\"3\"><font color=\"red\">" + _t("ANONYMITY WARNING - Settings include 1-hop tunnels.") + "</font></th></tr>");
+        }
         if (in.getLength() + Math.abs(in.getLengthVariance()) >= WARN_LENGTH ||
             out.getLength() + Math.abs(out.getLengthVariance()) >= WARN_LENGTH)

apps/routerconsole/java/src/net/i2p/router/web/helpers/NetDbRenderer.java

@@ -16 +16 @@
 import java.text.DecimalFormat;      // debug
 import java.util.ArrayList;
+import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
@@ -648 +649 @@
            .append(info.getIdentity().getSigningPublicKey().getType().toString());
         buf.append("</td></tr>\n<tr>")
-           .append("<td><b>" + _t("Address(es)") + ":</b></td>")
+           .append("<td><b>" + _t("Addresses") + ":</b></td>")
            .append("<td colspan=\"2\" class=\"netdb_addresses\">");
-        for (RouterAddress addr : info.getAddresses()) {
-            String style = addr.getTransportStyle();
-            buf.append("<br><b class=\"netdb_transport\">").append(DataHelper.stripHTML(style)).append(":</b>");
-            int cost = addr.getCost();
-            if (!((style.equals("SSU") && cost == 5) || (style.equals("NTCP") && cost == 10)))
-                buf.append("&nbsp;<span class=\"netdb_name\">").append(_t("cost")).append("</span>: <span class=\"netdb_info\">").append("" + cost).append("</span>&nbsp;");
-            Map<Object, Object> p = addr.getOptionsMap();
-            for (Map.Entry<Object, Object> e : p.entrySet()) {
-                String name = (String) e.getKey();
-                String val = (String) e.getValue();
-                buf.append(" <span class=\"nowrap\"><span class=\"netdb_name\">").append(_t(DataHelper.stripHTML(name)))
-                   .append(":</span> <span class=\"netdb_info\">").append(DataHelper.stripHTML(val)).append("</span></span>&nbsp;");
+        Collection<RouterAddress> addrs = info.getAddresses();
+        if (addrs.isEmpty()) {
+            buf.append(_t("none"));
+        } else {
+            for (RouterAddress addr : info.getAddresses()) {
+                String style = addr.getTransportStyle();
+                buf.append("<br><b class=\"netdb_transport\">").append(DataHelper.stripHTML(style)).append(":</b>");
+                int cost = addr.getCost();
+                if (!((style.equals("SSU") && cost == 5) || (style.equals("NTCP") && cost == 10)))
+                    buf.append("&nbsp;<span class=\"netdb_name\">").append(_t("cost")).append("</span>: <span class=\"netdb_info\">").append("" + cost).append("</span>&nbsp;");
+                Map<Object, Object> p = addr.getOptionsMap();
+                for (Map.Entry<Object, Object> e : p.entrySet()) {
+                    String name = (String) e.getKey();
+                    String val = (String) e.getValue();
+                    buf.append(" <span class=\"nowrap\"><span class=\"netdb_name\">").append(_t(DataHelper.stripHTML(name)))
+                       .append(":</span> <span class=\"netdb_info\">").append(DataHelper.stripHTML(val)).append("</span></span>&nbsp;");
+                }
             }
         }