Changeset 4b34b49 for apps/streaming

Timestamp:

Jul 27, 2015 6:32:53 AM (5 years ago)

Author:

str4d <str4d@…>

Branches:

master

Children:

db9555d

Parents:

1652bb3

Message:

More MessageInputStream? tests

File:

• apps/streaming/java/test/junit/net/i2p/client/streaming/impl/MessageInputStreamTest.java (modified) (4 diffs)

apps/streaming/java/test/junit/net/i2p/client/streaming/impl/MessageInputStreamTest.java

@@ -1 +1 @@
 package net.i2p.client.streaming.impl;
+
+import static org.hamcrest.Matchers.*;
+import static org.junit.Assert.*;
+import static org.mockito.Mockito.*;
 
 import java.io.IOException;
@@ -7 +11 @@
 import org.junit.After;
 import org.junit.Before;
+import org.junit.Rule;
 import org.junit.Test;
-
-import junit.framework.TestCase;
+import org.mockito.Mock;
+import org.mockito.junit.MockitoJUnit;
+import org.mockito.junit.MockitoRule;
+
 import net.i2p.I2PAppContext;
 import net.i2p.data.ByteArray;
@@ -18 +25 @@
  * Stress test the MessageInputStream
  */
-public class MessageInputStreamTest extends TestCase {
+public class MessageInputStreamTest {
+
+    @Rule
+    public MockitoRule rule = MockitoJUnit.rule();
+
     private I2PAppContext _context;
     private Log _log;
     private ConnectionOptions _options;
     private MessageInputStream in;
+
+    @Mock private PacketLocal packetLocal;
 
     @Before
@@ -37 +50 @@
     public void tearDown() {
         in.close();
+    }
+
+    @Test
+    public void testGetHighestReadyBlockId() {
+        assertThat(in.getHighestReadyBlockId(), is((long) -1));
+        in.messageReceived(0, new ByteArray());
+        assertThat(in.getHighestReadyBlockId(), is((long) 0));
+        in.messageReceived(2, new ByteArray());
+        assertThat(in.getHighestReadyBlockId(), is((long) 0));
+        in.messageReceived(1, new ByteArray());
+        assertThat(in.getHighestReadyBlockId(), is((long) 2));
+    }
+
+    @Test
+    public void testGetHighestBlockId() {
+        assertThat(in.getHighestBlockId(), is((long) -1));
+        in.messageReceived(0, new ByteArray());
+        assertThat(in.getHighestBlockId(), is((long) 0));
+        in.messageReceived(2, new ByteArray());
+        assertThat(in.getHighestBlockId(), is((long) 2));
+        in.messageReceived(1, new ByteArray());
+        assertThat(in.getHighestBlockId(), is((long) 2));
+    }
+
+    @Test
+    public void testCanAccept() {
+        // Can always accept packets with no data
+        assertTrue(in.canAccept(0, 0));
+        assertTrue(in.canAccept(0, -1));
+
+        // Can always accept packets with message ID < MIN_READY_BUFFERS (= 16)
+        assertTrue(in.canAccept(0, 1024));
+        assertTrue(in.canAccept(1, 1024));
+        assertTrue(in.canAccept(15, 1024));
+    }
+
+    @Test
+    public void testCanAccept_locallyClosed() {
+        // Fill the buffer
+        int numMsgs = _options.getInboundBufferSize() / _options.getMaxMessageSize();
+        byte orig[] = new byte[_options.getInboundBufferSize()];
+        _context.random().nextBytes(orig);
+        for (int i = 0; i < numMsgs; i++) {
+            byte msg[] = new byte[_options.getMaxMessageSize()];
+            System.arraycopy(orig, i*_options.getMaxMessageSize(), msg, 0, _options.getMaxMessageSize());
+            in.messageReceived(i, new ByteArray(msg));
+        }
+        // Check that new messages won't be accepted
+        assertFalse(in.canAccept(numMsgs, 1));
+        // Close
+        in.close();
+        // Check that new messages will now be accepted
+        assertTrue(in.canAccept(numMsgs, 1));
+    }
+
+    @Test
+    public void testCanAccept_allMaxSize() {
+        // Fill the buffer to one message under limit with max-size msgs
+        int numMsgs = _options.getInboundBufferSize() / _options.getMaxMessageSize();
+        byte orig[] = new byte[_options.getInboundBufferSize()];
+        _context.random().nextBytes(orig);
+        for (int i = 0; i < numMsgs - 1; i++) {
+            byte msg[] = new byte[_options.getMaxMessageSize()];
+            System.arraycopy(orig, i*_options.getMaxMessageSize(), msg, 0, _options.getMaxMessageSize());
+            in.messageReceived(i, new ByteArray(msg));
+        }
+        assertTrue(in.canAccept(numMsgs, 1));
+        byte msg[] = new byte[_options.getMaxMessageSize()];
+        System.arraycopy(orig, (numMsgs-1)*_options.getMaxMessageSize(), msg, 0, _options.getMaxMessageSize());
+        in.messageReceived(numMsgs - 1, new ByteArray(msg));
+        assertFalse(in.canAccept(numMsgs, 1));
+    }
+
+    @Test
+    public void testCanAccept_smallerMsgsWithMaxSizeCount() {
+        // Fill the buffer to one message under count that would reach limit with max-size msgs
+        int numMsgs = _options.getInboundBufferSize() / _options.getMaxMessageSize();
+        byte orig[] = new byte[numMsgs*1024];
+        _context.random().nextBytes(orig);
+        for (int i = 0; i < numMsgs - 1; i++) {
+            byte msg[] = new byte[1024];
+            System.arraycopy(orig, i*1024, msg, 0, 1024);
+            in.messageReceived(i, new ByteArray(msg));
+        }
+        assertTrue(in.canAccept(numMsgs, 1));
+        byte msg[] = new byte[1024];
+        System.arraycopy(orig, (numMsgs-1)*1024, msg, 0, 1024);
+        in.messageReceived(numMsgs - 1, new ByteArray(msg));
+        assertTrue(in.canAccept(numMsgs, 1));
+    }
+
+    @Test
+    public void testCanAccept_readyDup() {
+        // Fill the buffer
+        int numMsgs = _options.getInboundBufferSize() / _options.getMaxMessageSize();
+        byte orig[] = new byte[_options.getInboundBufferSize()];
+        _context.random().nextBytes(orig);
+        for (int i = 0; i < numMsgs; i++) {
+            byte msg[] = new byte[_options.getMaxMessageSize()];
+            System.arraycopy(orig, i*_options.getMaxMessageSize(), msg, 0, _options.getMaxMessageSize());
+            in.messageReceived(i, new ByteArray(msg));
+        }
+        // Check that new messages won't be accepted
+        assertFalse(in.canAccept(numMsgs, 1));
+        // Check that duplicate messages will be accepted
+        assertTrue(in.canAccept(numMsgs-1, 1));
+    }
+
+    @Test
+    public void testCanAccept_notReadyDup() {
+        // Fill the buffer
+        int numMsgs = _options.getInboundBufferSize() / _options.getMaxMessageSize();
+        byte orig[] = new byte[_options.getInboundBufferSize()];
+        _context.random().nextBytes(orig);
+        for (int i = 0; i < numMsgs; i++) {
+            byte msg[] = new byte[_options.getMaxMessageSize()];
+            System.arraycopy(orig, i*_options.getMaxMessageSize(), msg, 0, _options.getMaxMessageSize());
+            if (i == numMsgs-1)
+                in.messageReceived(numMsgs, new ByteArray(msg));
+            else
+                in.messageReceived(i, new ByteArray(msg));
+        }
+        // Check that duplicate notReady messages will be accepted
+        assertTrue(in.canAccept(numMsgs, 1));
+    }
+
+    @Test
+    public void testCanAccept_msgIdExceedsBuffer() {
+        // Fill the buffer to one message under limit with max-size msgs
+        int numMsgs = _options.getInboundBufferSize() / _options.getMaxMessageSize();
+        byte orig[] = new byte[_options.getInboundBufferSize()];
+        _context.random().nextBytes(orig);
+        for (int i = 0; i < numMsgs - 1; i++) {
+            byte msg[] = new byte[_options.getMaxMessageSize()];
+            System.arraycopy(orig, i*_options.getMaxMessageSize(), msg, 0, _options.getMaxMessageSize());
+            in.messageReceived(i, new ByteArray(msg));
+        }
+        // Add one half-size msg
+        byte msg[] = new byte[_options.getMaxMessageSize()/2];
+        System.arraycopy(orig, (numMsgs-1)*_options.getMaxMessageSize(), msg, 0, _options.getMaxMessageSize()/2);
+        in.messageReceived(numMsgs - 1, new ByteArray(msg));
+        // Check that it predicts only one more msgId will be accepted
+        assertTrue(in.canAccept(numMsgs, 1));
+        assertFalse(in.canAccept(numMsgs+1, 1));
+    }
+
+    @Test
+    public void testCanAccept_inOrderSmallMsgsDoS() {
+        // Fill the buffer to one message under count that would trip DoS protection
+        int numMsgs = 4 * _options.getMaxWindowSize();
+        byte orig[] = new byte[numMsgs];
+        _context.random().nextBytes(orig);
+        for (int i = 0; i < numMsgs - 1; i++) {
+            byte msg[] = new byte[1];
+            System.arraycopy(orig, i, msg, 0, 1);
+            in.messageReceived(i, new ByteArray(msg));
+        }
+        assertTrue(in.canAccept(numMsgs, 1));
+        // Trip DoS protection
+        byte msg[] = new byte[1];
+        System.arraycopy(orig, (numMsgs-1), msg, 0, 1);
+        in.messageReceived(numMsgs - 1, new ByteArray(msg));
+        assertFalse(in.canAccept(numMsgs, 1));
+    }
+
+    @Test
+    public void testGetNacks() {
+        assertThat(in.getNacks(), is(nullValue()));
+        in.messageReceived(0, new ByteArray());
+        assertThat(in.getNacks(), is(nullValue()));
+        in.messageReceived(2, new ByteArray());
+        assertThat(in.getNacks(), is(equalTo(new long[] {1})));
+        in.messageReceived(4, new ByteArray());
+        assertThat(in.getNacks(), is(equalTo(new long[] {1, 3})));
+        in.messageReceived(1, new ByteArray());
+        assertThat(in.getNacks(), is(equalTo(new long[] {3})));
+        in.messageReceived(3, new ByteArray());
+        assertThat(in.getNacks(), is(nullValue()));
+    }
+
+    @Test
+    public void testUpdateAcks_noMsgs() {
+        in.updateAcks(packetLocal);
+        verify(packetLocal).setAckThrough(-1);
+        verify(packetLocal).setNacks(null);
+    }
+
+    @Test
+    public void testUpdateAcks_inOrderMsgs() {
+        in.messageReceived(0, new ByteArray());
+        in.messageReceived(1, new ByteArray());
+        in.messageReceived(2, new ByteArray());
+        in.updateAcks(packetLocal);
+        verify(packetLocal).setAckThrough(2);
+        verify(packetLocal).setNacks(null);
+    }
+
+    @Test
+    public void testUpdateAcks_missingMsgs() {
+        in.messageReceived(0, new ByteArray());
+        in.messageReceived(2, new ByteArray());
+        in.updateAcks(packetLocal);
+        verify(packetLocal).setAckThrough(2);
+        verify(packetLocal).setNacks(new long[] {1});
+    }
+
+    @Test
+    public void testReadTimeout() {
+        assertThat(in.getReadTimeout(), is(-1));
+        in.setReadTimeout(100);
+        assertThat(in.getReadTimeout(), is(100));
     }