Changeset 5ede0a1

Timestamp:

Jun 9, 2019 11:48:03 AM (20 months ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

0c54b6d

Parents:

2c97dc2

Message:

UPnP: Set lease duration of 3 hours, always refresh the lease

File:

• router/java/src/net/i2p/router/transport/UPnP.java (modified) (2 diffs)

router/java/src/net/i2p/router/transport/UPnP.java

@@ -911 +911 @@
                 add.setArgumentValue("NewPortMappingDescription", description);
                 add.setArgumentValue("NewEnabled","1");
-                add.setArgumentValue("NewLeaseDuration", 0);
+                // 3 hours
+                // MUST be longer than max RI republish which is 52 minutes
+                add.setArgumentValue("NewLeaseDuration", 3*60*60);
                 
                 boolean rv = add.postControlAction();
@@ -1086 +1088 @@
                                 // Ports in portsToForwardNow but not in ports we must dump
                                 for(ForwardPort port: ports) {
+                                        // Always add, since we now have a 3 hour lease duration,
+                                        // so we have to keep refreshing the lease.
                                         //if(portsToForward.contains(port)) {
                                         // If not in portsForwarded, it wasn't successful, try again
-                                        if(portsForwarded.contains(port)) {
+                                        //if(portsForwarded.contains(port)) {
                                                 // We have forwarded it, and it should be forwarded, cool.
                                                 // Big problem here, if firewall resets, we don't know it.
                                                 // Do we need to re-forward anyway? or poll the router?
-                                        } else {
+                                        //} else {
                                                 // Needs forwarding
                                                 if(portsToForwardNow == null) portsToForwardNow = new HashSet<ForwardPort>();
                                                 portsToForwardNow.add(port);
-                                        }
+                                        //}
                                 }
                                 for(ForwardPort port : portsToForward) {