Changeset 7aa68c0

Timestamp:

May 2, 2019 10:41:50 PM (2 years ago)

Author:

meeh <meeh@…>

Branches:

master

Children:

8453c5cc

Parents:

811d1cc (diff), 52b14142 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

merge of '884fdac5153dc99fad97b61b1ef1172d8f0c09a9'

and 'c88b4076c5928a0e87d073abc0c0c94a341c921e'

Files:

• history.txt (modified) (1 diff)
• router/java/src/net/i2p/router/RouterVersion.java (modified) (1 diff)
• router/java/src/net/i2p/router/transport/crypto/DHSessionKeyBuilder.java (modified) (1 diff)
• router/java/src/net/i2p/router/transport/crypto/X25519KeyFactory.java (modified) (1 diff)

history.txt

@@ -1 +1 @@
 2019-05-02 zzz
+ * Android: Catch ISE from PRNG at shutdown (ticket #2077)
  * GeoIP Maxmind 2019-04-29
  * NTCP: Rare EventPumper 100% CPU fix (ticket #2476)

router/java/src/net/i2p/router/RouterVersion.java

@@ -19 +19 @@
     public final static String ID = "Monotone";
     public final static String VERSION = CoreVersion.VERSION;
-    public final static long BUILD = 11;
+    public final static long BUILD = 12;
 
     /** for example "-test" */

router/java/src/net/i2p/router/transport/crypto/DHSessionKeyBuilder.java

@@ -488 +488 @@
 
         public void run() {
+            try {
+                run2();
+            } catch (IllegalStateException ise) {
+                if (_isRunning)
+                    throw ise;
+                // else ignore, thread can be slow to shutdown on Android,
+                // PRNG gets stopped first and throws ISE
+            }
+        }
+
+        private void run2() {
             _isRunning = true;
             while (_isRunning) {

router/java/src/net/i2p/router/transport/crypto/X25519KeyFactory.java

@@ -78 +78 @@
 
     public void run() {
+        try {
+            run2();
+        } catch (IllegalStateException ise) {
+            if (_isRunning)
+                throw ise;
+            // else ignore, thread can be slow to shutdown on Android,
+            // PRNG gets stopped first and throws ISE
+        }
+    }
+
+    private void run2() {
         _isRunning = true;
         while (_isRunning) {