Changeset 847a441


Ignore:
Timestamp:
Jun 28, 2013 12:01:13 PM (7 years ago)
Author:
zzz <zzz@…>
Branches:
master
Children:
003dc378
Parents:
a5df6d4
Message:

disapproval of revision '8611baad56e8e18941721b156256783ba996a3cd'

Revert 8611baad56e8e18941721b156256783ba996a3cd
Don't use intern() on externally-supplied strings
as it could be used to exhaust memory

File:
1 edited

Legend:

Unmodified
Added
Removed
  • core/java/src/net/i2p/data/RouterAddress.java

    ra5df6d4 r847a441  
    216216        //_expiration = DataHelper.readDate(in);
    217217        DataHelper.readDate(in);
     218        _transportStyle = DataHelper.readString(in);
    218219        // reduce Object proliferation
    219         _transportStyle = DataHelper.readString(in).intern();
     220        if (_transportStyle.equals("SSU"))
     221            _transportStyle = "SSU";
     222        else if (_transportStyle.equals("NTCP"))
     223            _transportStyle = "NTCP";
    220224        DataHelper.readProperties(in, _options);
    221225    }
Note: See TracChangeset for help on using the changeset viewer.