Changeset a7485ab

Timestamp:

Jul 21, 2013 8:17:42 PM (7 years ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

cc271de

Parents:

7133736

Message:

• I2CP:
  • Oops, must enforce property length limits even when inside router JVM as the properties are serialized for signing.

Files:

• core/java/src/net/i2p/client/I2PSessionImpl.java (modified) (1 diff)
• router/java/src/net/i2p/router/RouterVersion.java (modified) (1 diff)

core/java/src/net/i2p/client/I2PSessionImpl.java

@@ -310 +310 @@
             }
             String val = options.getProperty(key);
-            // not serializing (no limit) in router ctx
+            // Long strings MUST be removed, even in router context,
+            // as the session config properties must be serialized to be signed.
             // fixme, bytes could still be over 255 (unlikely)
-            if ((!_context.isRouterContext()) &&
-                (key.length() > 255 || val.length() > 255)) {
+            if (key.length() > 255 || val.length() > 255) {
                 if (_log.shouldLog(Log.WARN))
                     _log.warn("Not passing on property ["

router/java/src/net/i2p/router/RouterVersion.java

@@ -19 +19 @@
     public final static String ID = "Monotone";
     public final static String VERSION = CoreVersion.VERSION;
-    public final static long BUILD = 7;
+    public final static long BUILD = 8;
 
     /** for example "-test" */