Changeset bdde11c

Timestamp:

Nov 8, 2015 6:14:42 PM (5 years ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

a3e16614

Parents:

63ddf11

Message:

Fix NPE from URL→URI conversion
new URL(null) throws MUE
new URI(null) throws NPE

File:

• apps/i2psnark/java/src/org/klomp/snark/TrackerClient.java (modified) (1 diff)

apps/i2psnark/java/src/org/klomp/snark/TrackerClient.java

@@ -876 +876 @@
 
   /**
-   *  @param ann an announce URL
+   *  @param ann an announce URL, may be null, returns false if null
    *  @return true for i2p hosts only
    *  @since 0.7.12
    */
   public static boolean isValidAnnounce(String ann) {
+    if (ann == null)
+        return false;
     URI url;
     try {
-       url = new URI(ann);
+        url = new URI(ann);
     } catch (URISyntaxException use) {
-       return false;
+        return false;
     }
     return "http".equals(url.getScheme()) && url.getHost() != null &&