Changeset e614b099

Timestamp:

Nov 8, 2016 3:42:22 PM (4 years ago)

Author:

zzz <zzz@…>

Branches:

master

Children:

e5bcfe4

Parents:

b559b41

Message:

Router: Fix low-memory log messages for non-wrapper (ticket #1795)
Install: Add max memory option to runplain.sh
Build: Fix minimum Java version for Windows

Files:

• installer/i2pinstaller.xml (modified) (1 diff)
• installer/i2pstandalone.xml (modified) (1 diff)
• installer/resources/runplain.sh (modified) (3 diffs)
• router/java/src/net/i2p/router/tasks/OOMListener.java (modified) (1 diff)
• router/java/src/net/i2p/router/tunnel/BloomFilterIVValidator.java (modified) (2 diffs)

installer/i2pinstaller.xml

@@ -8 +8 @@
   <icon>resources/console.ico</icon>
   <jre>
-    <minVersion>1.6.0</minVersion>
+    <minVersion>1.7.0</minVersion>
   </jre>
   <!--

installer/i2pstandalone.xml

@@ -8 +8 @@
   <icon>resources/start.ico</icon>
   <jre>
-    <minVersion>1.6.0</minVersion>
+    <minVersion>1.7.0</minVersion>
     <!--
     <minHeapSize>64</minHeapSize>

installer/resources/runplain.sh

@@ -4 +4 @@
 # This means the router will not restart if it crashes.
 # Also, you will be using the default memory size, which is
-# probably not enough for i2p.
+# probably not enough for i2p, unless you set it below.
 # You should really use the i2prouter script instead.
 #
@@ -19 +19 @@
 PREFERv4="false"
 CP=
+
+# Uncomment to set the maximum memory. The default and the option may vary in different JVMs.
+# Check your java documentation to be sure.
+#MAXMEMOPT="-Xmx256m"
 
 # Try using the Java binary that I2P was installed with.
@@ -40 +44 @@
     export JAVA_TOOL_OPTIONS="-Djava.awt.headless=true"
 fi
-JAVAOPTS="-Djava.net.preferIPv4Stack=${PREFERv4} -Djava.library.path=${I2P}:${I2P}/lib -Di2p.dir.base=${I2P} -DloggerFilenameOverride=logs/log-router-@.txt"
+JAVAOPTS="${MAXMEMOPT} -Djava.net.preferIPv4Stack=${PREFERv4} -Djava.library.path=${I2P}:${I2P}/lib -Di2p.dir.base=${I2P} -DloggerFilenameOverride=logs/log-router-@.txt"
 (
     nohup ${JAVA} -cp \"${CP}\" ${JAVAOPTS} net.i2p.router.RouterLaunch > /dev/null 2>&1

router/java/src/net/i2p/router/tasks/OOMListener.java

@@ -50 +50 @@
             log.log(Log.CRIT, "free mem: " + Runtime.getRuntime().freeMemory() + 
                               " total mem: " + Runtime.getRuntime().totalMemory());
+            // Can't find any System property or wrapper property that gives
+            // you the actual config file path, have to guess
+            String path;
+            if (SystemVersion.isLinuxService()) {
+                path = "/etc/i2p";
+            } else {
+                path = _context.getBaseDir().toString();
+            }
             if (_context.hasWrapper()) {
-                // Can't find any System property or wrapper property that gives
-                // you the actual config file path, have to guess
-                String path;
-                if (SystemVersion.isLinuxService()) {
-                    path = "/etc/i2p";
-                } else {
-                    path = _context.getBaseDir().toString();
-                }
                 log.log(Log.CRIT, "To prevent future shutdowns, increase wrapper.java.maxmemory in " +
+                                  path + File.separatorChar + "wrapper.config");
+            } else if (!SystemVersion.isWindows()) {
+                log.log(Log.CRIT, "To prevent future shutdowns, increase MAXMEMOPT in " +
+                                  path + File.separatorChar + "runplain.sh or /usr/bin/i2prouter-nowrapper");
+            } else {
+                log.log(Log.CRIT, "To prevent future shutdowns, run the restartable version of I2P, and increase wrapper.java.maxmemory in " +
                                   path + File.separatorChar + "wrapper.config");
             }

router/java/src/net/i2p/router/tunnel/BloomFilterIVValidator.java

@@ -105 +105 @@
         // Can't find any System property or wrapper property that gives
         // you the actual config file path, have to guess
-        // TODO if !SystemVersion.hasWrapper ...
         String path;
         if (SystemVersion.isLinuxService()) {
@@ -115 +114 @@
             "Configured for " + DataHelper.formatSize(KBps *1024L) +
             "Bps share bandwidth but only " +
-            DataHelper.formatSize(maxMemory) + "B available memory." +
-            " Recommend increasing wrapper.java.maxmemory in " +
-            path + File.separatorChar + "wrapper.config" +
-            // getMaxMemory() returns significantly lower than wrapper config, so add 10%
-            " to at least " + (recMaxMem * 11 / 10 / (1024*1024)) + " (MB)" +
-            " if the actual share bandwidth exceeds " +
-            DataHelper.formatSize(threshKBps * 1024L) + "Bps.";
+            DataHelper.formatSize(maxMemory) + "B available memory.";
+        if (_context.hasWrapper()) {
+            msg += " Recommend increasing wrapper.java.maxmemory in " +
+                   path + File.separatorChar + "wrapper.config";
+        } else if (!SystemVersion.isWindows()) {
+            msg += " Recommend increasing MAXMEMOPT in " +
+                   path + File.separatorChar + "runplain.sh or /usr/bin/i2prouter-nowrapper";
+        } else {
+            msg += " Recommend running the restartable version of I2P, and increasing wrapper.java.maxmemory in " +
+                   path + File.separatorChar + "wrapper.config";
+        }
+        // getMaxMemory() returns significantly lower than wrapper config, so add 10%
+        msg += " to at least " + (recMaxMem * 11 / 10 / (1024*1024)) + " (MB)" +
+               " if the actual share bandwidth exceeds " +
+               DataHelper.formatSize(threshKBps * 1024L) + "Bps.";
         System.out.println("WARN: " + msg);
         _context.logManager().getLog(BloomFilterIVValidator.class).logAlways(Log.WARN, msg);