Changeset e64ad7c for apps


Ignore:
Timestamp:
Aug 26, 2018 3:13:49 PM (23 months ago)
Author:
zzz <zzz@…>
Branches:
master
Children:
c9002b32, f6c4535
Parents:
1f92232
Message:

More findbugs all over

Location:
apps
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • apps/addressbook/java/src/net/i2p/addressbook/Daemon.java

    r1f92232 re64ad7c  
    177177                               NamingService publishedNS, AddressBook addressbook,
    178178                               Iterator<Map.Entry<String, HostTxtEntry>> iter, Log log) {
    179             long start = System.currentTimeMillis();
     179            long start = DEBUG ? System.currentTimeMillis() : 0;
    180180            int old = 0, nnew = 0, invalid = 0, conflict = 0, total = 0;
    181181            int deleted = 0;
  • apps/routerconsole/java/src/net/i2p/router/web/helpers/ConfigAdvancedHandler.java

    r1f92232 re64ad7c  
    108108        if (_ff.equals("false") || _ff.equals("true")) {
    109109            FloodfillNetworkDatabaseFacade fndf = (FloodfillNetworkDatabaseFacade) _context.netDb();
    110             boolean wasFF = fndf.floodfillEnabled();
    111110            boolean isFF = _ff.equals("true");
    112111            // this will rebuild the RI, log in the event log, etc.
  • apps/streaming/java/src/net/i2p/client/streaming/impl/PacketHandler.java

    r1f92232 re64ad7c  
    282282                        if (_log.shouldLog(Log.INFO))
    283283                            _log.info("Received additional packet w/o SendStreamID after the syn on " + con + ": " + packet);
    284                         receiveKnownCon(con, packet);
    285                         return;
    286284                    } else {
    287285                        if (_log.shouldLog(Log.WARN))
    288286                            _log.warn("hrmph, received while ack of syn was in flight on " + con + ": " + packet + " acked: " + con.getAckedPackets());
    289287                        // allow unlimited packets without a SendStreamID for now
    290                         receiveKnownCon(con, packet);
    291                         return;
    292                     }
     288                    }
     289                    receiveKnownCon(con, packet);
     290                    return;
    293291                }
    294292            } else {
     
    300298                }
    301299                // don't bother sending reset
     300                // TODO send reset if recent && has data?
    302301                packet.releasePayload();
    303302                return;
  • apps/susimail/src/src/i2p/susi/webmail/WebMail.java

    r1f92232 re64ad7c  
    26232623                ArrayList<String> bccList = new ArrayList<String>();
    26242624               
    2625                 String sender = null;
    2626                 if (from != null && Mail.validateAddress(from)) {
    2627                         sender = Mail.getAddress( from );
    2628                 }
    2629                
    26302625                // no validation
    26312626                Mail.getRecipientsFromList( toList, to, ok );
     
    27322727                String[] bcc = draft.getBcc();
    27332728                String subject = draft.subject;
    2734                 MailPart text = draft.getPart();
    27352729                List<Attachment> attachments = draft.getAttachments();
    27362730
     
    29732967                        I2PAppContext ctx = I2PAppContext.getGlobalContext();
    29742968                        b64UIDL = Base64.encode(ctx.random().nextLong() + "drft");
    2975                 } else {
     2969                }
     2970
    29762971                        MailCache drafts = sessionObject.caches.get(DIR_DRAFTS);
    29772972                        if (drafts == null) {
     
    30083003                                out.println("<input type=\"hidden\" name=\"" + DRAFT_EXISTS + "\" value=\"1\">");
    30093004                        }
    3010                 }
    30113005
    30123006                boolean fixed = Boolean.parseBoolean(Config.getProperty( CONFIG_SENDER_FIXED, "true" ));
Note: See TracChangeset for help on using the changeset viewer.