Custom Query (1911 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (31 - 33 of 1911)

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21
Ticket Resolution Summary Owner Reporter
#1198 fixed More efficient InetAddress methods Inondle Zlatin Balevsky
Description

The following two methods verify whether a string is a numerical IP address in a very inefficient and incorrect manner.

net.i2p.data.RouterAddress::getIP() net.i2p.util.Addresses::getIP(String)

They should be rewritten to properly catch all invalid IP addresses and not create any temporary objects (garbage).

Also, JUnit tests should be provided for both.

#369 duplicate Potential resource leaks in net.i2p.util.FileUtil John Doo John Doo
Description

I've noticed a potential resource leak in net.i2p.util.FileUtil?.copy(String source, String dest, boolean overwriteExisting, boolean quiet).

The input- and output-streams are closed in the try-block. This is a fault, as the streams never get closed if any one of the previous statements causes an exception. The correct way to do this is to close the streams in a finally-block.

readFile(String path, String root, OutputStream? out) contains potentially the same fault for the output stream, but maybe it's by intention to close the output stream only if the whole file was read successfully.

Yours sincerely John Doo

#328 fixed Add https support to r31453.ovh.net Mathiasdm zzz
Description

For reseeding

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21
Note: See TracQuery for help on using queries.