Custom Query (1911 matches)

Filters
 
Or
 
  
 
Columns

Show under each result:


Results (52 - 54 of 1911)

Ticket Resolution Summary Owner Reporter
#436 fixed Platform dependent encoding instead of UTF-8 in DataHelper zzz John Doo
Description

net.i2p.data.DataHelper? contains the following lines:

private final static byte SEMICOLON_BYTES[] = ";".getBytes(); in UTF-8 private final static byte EQUAL_BYTES[] = "=".getBytes(); in UTF-8

As the comment already says, the byte-arrays are supposed to contain an UTF-8 encoding of ';' and '=', but actually they contain an platform-dependent encoding. So I suggest to replace it by:

private static final Charset UTF_8 = Charset.forName("UTF-8"); private static final byte[] EQUAL_BYTES = "=".getBytes(UTF_8); in UTF-8 private static final byte[] SEMICOLON_BYTES = ";".getBytes(UTF_8); in UTF-8

[Using a (final static) Charset has the advantage that's not necessary to put getBytes in a try-catch-clause.]

#437 fixed Superfluous comparisons in DataHelper.eq(byte[], byte[]) John Doo
Description

net.i2p.data.DataHelper?.eq(byte[], byte[]) performs superfluous comparisons, as someone in a comment already suspected:

this appears to be the way Arrays.equals is defined, so all the extra tests are unnecessary?

boolean eq = (((lhs == null) && (rhs == null))
((lhs != null) &&(rhs != null) && (Arrays.equals(lhs, rhs))));

return eq;

I can confirm that Arrays.equals returns exactly the same results as this expression, so I suggest to replace it by: return Arrays.equals(lhs, rhs);

#838 fixed I2PBote Errors HungryHobo L0rD`
Description

[I2PSendQueue] i2p.bote.network.I2PSendQueue : Can't send packet.

java.net.NoRouteToHostException?: Connection timed out at net.i2p.client.streaming.I2PSocketManagerFull.connect(I2PSocketManagerFull.java:241) at net.i2p.client.streaming.I2PSocketManagerFull.connect(I2PSocketManagerFull.java:260) at i2p.bote.network.I2PSendQueue.sendStream(I2PSendQueue.java:284) at i2p.bote.network.I2PSendQueue.send(I2PSendQueue.java:254) at i2p.bote.network.I2PSendQueue.doStep(I2PSendQueue.java:207) at i2p.bote.service.I2PBoteThread.run(I2PBoteThread.java:77)

[Kademlia ] ademlia.ClosestNodesLookupTask?: Lookup for closest nodes timed out.

[OutboxProcsr?] p.bote.service.OutboxProcessor?: Can't scan outbox.

i2p.bote.fileencryption.PasswordException? at i2p.bote.fileencryption.EncryptedInputStream?.<init>(EncryptedInputStream?.java:59) at i2p.bote.email.Email.<init>(Email.java:118) at i2p.bote.folder.EmailFolder?.createFolderElement(EmailFolder?.java:421) at i2p.bote.folder.EmailFolder?.createFolderElement(EmailFolder?.java:57) at i2p.bote.folder.Folder$3.findNextElement(Folder.java:154) at i2p.bote.folder.Folder$3.hasNext(Folder.java:122) at i2p.bote.service.OutboxProcessor?.doStep(OutboxProcessor?.java:99) at i2p.bote.service.I2PBoteThread.run(I2PBoteThread.java:77)

(These messages repeat ∞ in the log-router-1.txt )

I2P version: 0.9.4-0 Java version: Oracle Corporation 1.7.0_09 (OpenJDK Runtime Environment 1.7.0_09-b30) Wrapper version: 3.1.1 Server version: 6.1.26 Servlet version: Jasper JSP 2.1 Engine Platform: Linux i386 3.5.0-21-generic Processor: uninitialized (core2) Jbigi: Locally optimized native BigInteger? library loaded from file Encoding: UTF-8 Charset: UTF-8

Note: See TracQuery for help on using queries.