Opened 6 years ago
Closed 6 years ago
#1007 closed enhancement (fixed)
Only use non-retransmitted packets in RTT sampling (RFC 6298)
| Reported by: | Zlatin Balevsky | Owned by: | Zlatin Balevsky |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.9.8 |
| Component: | streaming | Version: | 0.9.7.1 |
| Keywords: | Cc: | zab@… | |
| Parent Tickets: | Sensitive: | no |
Description
From http://tools.ietf.org/html/rfc6298
3. Taking RTT Samples TCP MUST use Karn's algorithm [KP87] for taking RTT samples. That is, RTT samples MUST NOT be made using segments that were retransmitted (and thus for which it is ambiguous whether the reply was for the first instance of the packet or a later instance).
One possible implementation: http://pastethis.i2p/show/4606/
Subtickets
Change History (3)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
ack (no pun), proposal and patch look good.
You can replace one more p.getAckTime() with ackTime at line 305.
comment:3 Changed 6 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Should be in trunk in revision 5f8111a4038de90d9696f325cb6b2636d56cfd06
Note: See
TracTickets for help on using
tickets.
Digging through the mtn history, the original behavior was the correct one, but revision 007b01bea8c493cdad998838fc093ec9517145e8 (2004, jrandom) changed it.