Opened 8 years ago

Closed 4 years ago

Last modified 4 years ago

#1068 closed enhancement (fixed)

Combine Jetty HashSessionScavenger threads

Reported by: zzz Owned by: zzz
Priority: minor Milestone: 0.9.29
Component: apps/console Version:
Keywords: performance memory Cc:
Parent Tickets: Sensitive: no


Due to the way we construct the authorization realms for each webapp, we end up with a Jetty HashSessionScavenger? thread for each webapp - 6 total. Can we set things up so that there's only a single thread? See RouterConsoleRunner?.


Change History (8)

comment:1 Changed 7 years ago by str4d

Keywords: performance memory added
Milestone: 0.9.12

comment:2 Changed 5 years ago by str4d

Status: newopen

comment:3 Changed 5 years ago by zzz

Milestone: 0.9.29
Owner: set to zzz
Status: openaccepted

comment:4 Changed 4 years ago by zzz

Resolution: fixed
Status: acceptedclosed

Left it per-webapp scoped, but set a common Timer.
In 19d1077baddf272f3d277fd06c996741f7f74e21 to be 0.9.28-6

comment:5 Changed 4 years ago by zzz

Resolution: fixed
Status: closedreopened

This had to be reworked a little for Jetty 9, but it now causes the Jetty logging rollover to kill the timer, and that stops rollover from working:

        2017/xx/xx 00:00:00 | Exception in thread "org.eclipse.jetty.util.RolloverFileOutputStream" java.lang.IllegalStateException: 
Task already scheduled or cancelled
        2017/xx/xx 00:00:00 |	at java.util.Timer.sched(
        2017/xx/xx 00:00:00 |	at java.util.Timer.schedule(
        2017/xx/xx 00:00:00 |	at org.eclipse.jetty.util.RolloverFileOutputStream.scheduleNextRollover(
        2017/xx/xx 00:00:00 |	at org.eclipse.jetty.util.RolloverFileOutputStream.access$200(
        2017/xx/xx 00:00:00 |	at org.eclipse.jetty.util.RolloverFileOutputStream$
        2017/xx/xx 00:00:00 | 	at java.util.TimerThread.mainLoop(
        2017/xx/xx 00:00:00 | 	at

reverted in 0.9.29-19-rc 7968baeff75d23fa6561bbbe86620feb4dd97f41
to be investigated for 0.9.31

comment:6 Changed 4 years ago by zzz

above change didn't fix it.
It's a Jetty bug
It's fixed in 9.4.4
but there's no backport to 9.2.x

On further review, I don't think this ever had anything to do with the HashSessionScavenger? issue.

comment:7 Changed 4 years ago by zzz

Milestone: 0.9.310.9.29
Resolution: fixed
Status: reopenedclosed

Change reverted in 0.9.29-20-rc, Jetty patched. Not fully tested, but closing this ticket again since the Jetty issue is unrelated.

comment:8 Changed 4 years ago by zzz

Separate ticket on the rollover issue #2013

Note: See TracTickets for help on using tickets.