Opened 5 years ago

Closed 5 years ago

#1070 closed defect (fixed)

Clearing blacklist causes streaming NPE

Reported by: zzz Owned by:
Priority: minor Milestone: 0.9.9
Component: streaming Version: 0.9.8.1
Keywords: Cc:
Parent Tickets:

Description

Cleared all previous blacklist entries but left blacklist enabled in i2ptunnel HTTP server tunnel GUI.

Subsequent NPE killed the whole tunnel. Following is from wrapper log (relatively new log message paid off), nothing in router log:

 Thread terminated unexpectedly: Server /127.0.0.1:xxxx
 java.lang.NullPointerException
        at net.i2p.client.streaming.ConnectionManager.shouldRejectConnection(ConnectionManager.java:448)
        at net.i2p.client.streaming.ConnectionManager.receiveConnection(ConnectionManager.java:215)
        at net.i2p.client.streaming.ConnectionHandler.accept(ConnectionHandler.java:175)
        at net.i2p.client.streaming.I2PSocketManagerFull.receiveSocket(I2PSocketManagerFull.java:128)
        at net.i2p.client.streaming.I2PServerSocketFull.accept(I2PServerSocketFull.java:26)
        at net.i2p.i2ptunnel.I2PTunnelServer.run(I2PTunnelServer.java:379)
        at java.lang.Thread.run(Thread.java:595)
        at net.i2p.util.I2PThread.run(I2PThread.java:85)

Pretty sure this was in test2 branch, close to 0.9.8.1 but line numbers may not match trunk. Apparently _defaultOptions was null? but need to reproduce, that may not be right as I can't for sure match up the source to the test version I was running. Seems more likely that _currentBlacklist was null.

For further testing and attempts to reproduce with a known version.

Subtickets

Change History (3)

comment:1 Changed 5 years ago by zzz

Also fix it so an exception in receiveConnection() doesn't kill the accept loop. That's not good.

comment:2 Changed 5 years ago by zzz

accept loop issue fixed in 378cbb865b9a9699ac331a1be25be803a6adbd5a 0.9.8.1-10

comment:3 Changed 5 years ago by zzz

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in ed228531b9b482bfe087d099f6adf45ef4c0a351 0.9.8.1-10 but it caused an even worse problem, instantiation of the tunnel crashed if there was a blacklist enabled with at least one entry.

That issue fixed in 0baa155607e020e56c577e4c18ae109838e3825b 0.9.8.1-13

Note: See TracTickets for help on using tickets.