Opened 7 years ago
Closed 7 years ago
#1123 closed defect (fixed)
Handle multiple UPnP devices better
Reported by: | zzz | Owned by: | zzz |
---|---|---|---|
Priority: | minor | Milestone: | 0.9.9 |
Component: | router/transport | Version: | 0.9.8.1 |
Keywords: | UPnP | Cc: | |
Parent Tickets: | Sensitive: | no |
Description
We currently take the first one we find and ignore the rest. As the first-to-respond is not deterministic, behavior on a computer with access to multiple UPnP devices (either on the same or different subnets; the realistic case is different subnets).
Need (at least) some advanced config to ignore certain ones or specify priority.
Even better, a GUI.
Even better, pick the "best" one algorithmically (the one that's on the default route, for example). But I'm sure that's hard. Maybe the one "closest" to our configured IP? But we don't usually have an IP configured.
Check freenet (limewire?) for any fixes they have done (the code came from them). Not likely though.
To maintain a reference to all devices found (rather than just discarding ones we don't like) would require significant rework in UPnP.java.
Subtickets
Change History (3)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
Milestone: | 0.9.12 → 0.9.9 |
---|---|
Status: | new → accepted |
comment:3 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | accepted → closed |
Fixed in 0.9.8.1-24 0a9e37137968d793f6a1644eb653353f2345107a
- Add new config i2np.upnp.ignore to specify UDNs of ignored devices
- Add display of ignored devices on /peers
Example log: