Opened 6 years ago

Closed 6 years ago

#1135 closed task (fixed)

Move streaming impl to new package

Reported by: zzz Owned by: dg
Priority: minor Milestone: 0.9.10
Component: streaming Version: 0.9.8.1
Keywords: Cc: zab@…, dg
Parent Tickets: Sensitive: no

Description

Streaming is oddly split across ministreaming.jar (apps/ministreaming) and streaming.jar (apps/streaming) but they share the same package net.i2p.client.streaming.

This is a result of history as there originally was a very simple ministreaming library, and later came the "full" streaming library. The ministreaming implementation is long gone and everything in the "full" lib is essentially the implementation, all package private. What remains in ministreaming is the interfaces, public classes, factory, and SocketEepGet?.

As they share the same package it makes the javadocs a mess. The public classes and the implementation are all smashed together. So let's fix this by splitting up the packages and therefore the javadocs.

As everything in the implementation is package private, we should be able to move the entire implementation (i.e. what's in apps/streaming) to net.i2p.client.streaming.impl without breaking anything and retaining compatibility.

Do not change the way we build the jars. Still two jars, ministreaming and streaming. Still two apps/ dirs, ministreaming and streaming.

Subtickets

Change History (5)

comment:1 Changed 6 years ago by Zlatin Balevsky

Cc: zab@… added

comment:2 Changed 6 years ago by zzz

Cc: dg added

I believe dg started this? If you did and plan to finish it, please assign it to yourself. If you abandoned the effort please let us know so somebody else can do it.

comment:3 in reply to:  2 Changed 6 years ago by dg

Owner: set to dg
Status: newaccepted

Replying to zzz:

I believe dg started this? If you did and plan to finish it, please assign it to yourself. If you abandoned the effort please let us know so somebody else can do it.

I began it, ran into some issues. I'll investigate after Xmas.

comment:4 Changed 6 years ago by dg

Milestone: 0.9.120.9.10
Status: acceptedtesting

Fixed in 0.9.9-4 c1533191d292cff36b78951d0ff9c6a9abd1df7e.
Setting to 'testing'.

comment:5 Changed 6 years ago by dg

Resolution: fixed
Status: testingclosed

Closing. This is in 0.9.10.

Note: See TracTickets for help on using tickets.