Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#1136 closed defect (fixed)

HTTP/HTTPS reseed preferences ignored if reseed list changed

Reported by: backup Owned by: Inondle
Priority: minor Milestone: 0.9.20
Component: router/general Version: 0.9.8.1
Keywords: reseed docs easy review-needed Cc:
Parent Tickets: Sensitive: no

Description

Reseeding is set to: "Try SSL first then non-SSL"
with 2 URLS:
https://ieb9oopo.mooo.com
http://ieb9oopo.mooo.com

The setting "Try SSL first then non-SSL" is not working correct, the log shows reseeding is only done by http:
2013/11/25 19:20:25 | Reseed start
2013/11/25 19:20:25 | Reseeding from http://ieb9oopo.mooo.com
2013/11/25 19:20:33 | Reseed got 68 router infos from http://ieb9oopo.mooo.com with 0 errors
2013/11/25 19:20:33 | Reseed complete, 68 received

Deleting the http URL or setting the option to "Use SSL only" works fine:
2013/11/25 19:11:49 | Reseed start
2013/11/25 19:11:49 | Reseeding from https://ieb9oopo.mooo.com
2013/11/25 19:12:25 | Reseed got 68 router infos from https://ieb9oopo.mooo.com with 0 errors
2013/11/25 19:12:25 | Reseed complete, 68 received

Thanks
backup


I2P version: 0.9.8.1-32-rc
Java version: Oracle Corporation 1.7.0_25 (OpenJDK Runtime Environment 1.7.0_25-b30)
Wrapper version: 3.5.19
Server version: 7.6.13.v20130916
Servlet version: Jasper JSP 2.1 Engine
Platform: Linux amd64 3.11.0-13-generic
Processor: Atom (atom)
Jbigi: Locally optimized native BigInteger? library loaded from file
Encoding: UTF-8
Charset: UTF-8

Subtickets

Attachments (1)

1136.patch (4.3 KB) - added by Inondle 4 years ago.
patch to allow ssl or non-ssl preferences on custom reseed url lists

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by str4d

If you don't use the default list, the reseeder ignores HTTP/HTTPS preferences and uses the list randomly. This assumes that if the user specifies what reseed urls to use, they know what they are doing. Maybe this should be changed.

While looking into this, I found and fixed another bug - requiring SSL with the default list did nothing (the HTTP list was still appended to the HTTPS list). But if you are editing the url list, this would not affect you.

comment:2 Changed 5 years ago by str4d

Keywords: reseed easy added
Milestone: 0.9.9

comment:3 Changed 5 years ago by str4d

Keywords: docs added
Summary: Reseeding with "Try SSL first then non-SSL" uses non-SSL firstHTTP/HTTPS reseed preferences ignored if reseed list changed

#1349 points out another symptom:

SSL-only reseed setting ignored if reseed list changed

Non-intuitive and not explained. The checkbox only works if your reseed list is the default. Either change the UI or change the reseed code (Reseeder.java line ~293)

http://forum.i2p/viewtopic.php?t=11523

comment:4 Changed 4 years ago by Inondle

Hi, I think I figured out why it ignores ssl preferences if the list has been changed. In net.i2p.router.networkdb.reseed.Reseeder.java in the reseed(boolean echoStatus) method there is a boolean defaulted that is set to true if the list is the default list and false if there is a custom list saved. If true, this will gather only non-ssl defaults or only ssl urls or both (depending on user preference).

if defaulted is false, there is no checking of the list against user preferences, the urls are simply chosen at random.

Last edited 4 years ago by Inondle (previous) (diff)

comment:5 Changed 4 years ago by Inondle

Keywords: review-needed added
Owner: set to Inondle
Status: newassigned

Changed 4 years ago by Inondle

Attachment: 1136.patch added

patch to allow ssl or non-ssl preferences on custom reseed url lists

comment:6 Changed 4 years ago by zzz

Milestone: 0.9.20
Resolution: fixed
Status: assignedclosed

patch cleaned up, tested, applied in a811c569d6ca3835db40ae465896a45c2f3e5285 0.9.19-6 thank you

comment:7 Changed 4 years ago by zzz

This is also good to do, even if we're removing HTTP URLs (#1514), because the /configreseed form will save the URL list, even if you just change the SSL/non-SSL setting. So anybody who has saved on this form has a non-default list.

Additional change to add a message if there's no valid URL, and removal of HTTP defaults (#1514) also included in 0.9.19-6.

Note: See TracTickets for help on using tickets.