Opened 5 years ago

Closed 5 years ago

#1142 closed defect (fixed)

Streaming ping - throttle or disable by default

Reported by: zzz Owned by: zzz
Priority: minor Milestone: 0.9.12
Component: streaming Version: 0.9.8.1
Keywords: easy maybe Cc:
Parent Tickets:

Description

Several problems with streaming pings:

  • Enabled by default (i2p.streaming.answerPings=true)
  • Whitelist and blacklist options do not apply to pings
  • No rate limiting

We do not return the payload from a ping in the pong so it isn't a huge DoS vector but it could still cause trouble.

Easiest thing to do would be to change the default to false in streaming. We could, instead, set the option in i2ptunnel (only for clients? or servers too?)

There's no known application that uses streaming pings other than the I2Ping tunnel, only accessible via the I2PTunnel CLI.

See also newly enhanced ping docs in http://www.i2p2.i2p/streaming

Subtickets

Change History (5)

comment:1 Changed 5 years ago by zzz

  • Owner set to zzz
  • Status changed from new to accepted

Disabled in i2ptunnel ClientBase? and i2psnark in i2p.i2p.zzz.test2 aa00bbb07acf39680e651b586847c5c85952f590 to be propped for 0.9.10. Servers TBD.

comment:2 Changed 5 years ago by zzz

  • Milestone changed from 0.9.10 to 0.9.12

Throttling in 9493a0557f1e0a8a95ae6209f369a874cdc914cd i2p.i2p.zzz.test2 to be propped for 0.9.12

comment:3 Changed 5 years ago by zzz

propped in 0.9.11-2

still need rate limiting even in the absence of conn limits?

comment:4 Changed 5 years ago by zzz

All the above is in 0.9.12. What more should we do if anything?

comment:5 Changed 5 years ago by zzz

  • Resolution set to fixed
  • Status changed from accepted to closed

Will open new ticket if we think of more to do.

Note: See TracTickets for help on using tickets.