Opened 5 years ago

Closed 14 months ago

Last modified 14 months ago

#1184 closed defect (wontfix)

Remove external proxy support for news fetching

Reported by: vi Owned by:
Priority: minor Milestone: 0.9.34
Component: router/update Version: 0.9.10
Keywords: Cc:
Parent Tickets:

Description (last modified by zzz)

I see big block binary data (like "$4�%�&'()*56789:CDEFGHIJSTUVWXYZcdefghijstuvwxyz�������������") on my I2P router home page in "News" section.

With "Inspect Element" I see that the data is actually a part of MJPEG stream coming from other port on the same host, not I2P-related...

I also see that data if I do curl http://127.0.0.1:7657/home.

How can unrelated data get into I2P router news?

Subtickets

Change History (6)

comment:1 Changed 5 years ago by vi

Info: HTTP client tunnel was stopped at all, but unrelated service is listening 0.0.0.0:4444.

I think I2P should use the port of HTTP tunnel (not hard coded 4444) for fetching news and just don't fetch any news if HTTP tunnel is stopped.

comment:2 Changed 5 years ago by zzz

  • Component changed from unspecified to router/update
  • Description modified (diff)

That explains it.

Yes we do fallback to external 4444 if the internal 4444 is not present. That's somewhat leftover from the days where all proxy traffic went out-and-back-in.

So the question is whether we should continue to support external proxies or just disallow them and use internal-only.

comment:3 Changed 5 years ago by vi

What is an an "external proxy"? A separate java process that connects to the router using "I2P Client Protocol" (possibly running on other host) and opens HTTP client tunnel?

If such scheme is supported, it should continue to be supported (how to do it BTW? Is there a guide of running I2P router on one host, but address book and hosts.txt on the other).

Fetching news only though internal proxy (otherwise not fetching at all) is a good idea. Ability to inject any code to "news" section of the router just by opening unprivileged 4444 port is a security issue.

comment:4 Changed 5 years ago by str4d

  • Milestone 0.9.11 deleted
  • Summary changed from Binary garbage instead of news on router home page. to Remove external proxy support for news fetching

Renaming ticket for clarity. If we do decide to keep external proxy support, we can close the ticket as wontfix.

comment:5 Changed 14 months ago by echelon

  • Resolution set to wontfix
  • Status changed from new to closed

comment:6 Changed 14 months ago by zzz

  • Milestone set to 0.9.34

This is now hidden unless routerconsole.advanced=true
some parts were disabled or hidden earlier, and the last of it hidden as of #2182 fix to be 0.9.33-9

Note: See TracTickets for help on using tickets.