Opened 5 years ago

Closed 4 years ago

#1189 closed defect (fixed)

Speed test / replace MD5Digest with JVM version

Reported by: zzz Owned by: zzz
Priority: maintenance Milestone: 0.9.12
Component: api/crypto Version: 0.9.10
Keywords: Cc:
Parent Tickets:


In org.bouncycastle.oldcrypto, used in SSU HMAC.

Evaluate with multiple JVMs, switch none, some, or all JVMs to JVM version depending on speed test results. All JVMs should have MD5 support. Test for identical results.

JVM version example is in net.i2p.util.PasswordManager?.md5Sum() but we need to call update() on-the-fly.

Examples of speed/comparison tests are in net.i2p.crypto.

Take care not to break any compatibility, or does this matter anymore since we renamed it to oldcrypto?

I assume we can't use a standard JVM MAC since we are non-standard but maybe there's a way if it's configured right, look into that too.


Change History (3)

comment:1 Changed 5 years ago by zzz

  • Owner set to zzz
  • Status changed from new to accepted


May also update HMAC256Generator to use the JVM too, it's compatible. If I can do it without breaking Syndie.

comment:2 Changed 5 years ago by zzz

  • Milestone changed from 0.9.15 to 0.9.12
  • Status changed from accepted to testing

In 0.9.11-5 4052c7a173fac73ba45619ba8ea8bf746042c336

comment:3 Changed 4 years ago by zzz

  • Resolution set to fixed
  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.