Changes between Version 2 and Version 3 of Ticket #1198, comment 10


Ignore:
Timestamp:
Feb 27, 2015 5:02:23 AM (6 years ago)
Author:
Inondle
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1198, comment 10

    v2 v3  
    1 Ok, so I've made the IP patterns static final Strings and made getter methods so `RouterAddress.getIP()` can use them. I've cleaned up both those methods and fixed that host checking mistake. I will work on the `RouterAddress.getIP()` JUnit tests. Was the `Addresses.getIP()` test ok? I think that one mocked the `InetAddress.getByName(host)` call pretty well, is there anything I need to improve in those tests?
     1Ok, so I've made the IP patterns static final pre-compiled Patterns and made getter methods so `RouterAddress.getIP()` can use them. I've cleaned up both those methods and fixed that host checking mistake. I will work on the `RouterAddress.getIP()` JUnit tests. Was the `Addresses.getIP()` tests in IPAddressPatternTest ok? I think that one mocked the `InetAddress.getByName(host)` call pretty well, is there anything I need to improve in those tests?