Opened 11 years ago

Closed 11 years ago

#12 closed enhancement (fixed)

one file per class

Reported by: mkvore Owned by: zzz
Priority: minor Milestone: 0.6.5
Component: router/general Version:
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

I would like somebody to split the file

  • net/i2p/router/networkdb/kademlia/SearchJob.java
  • net/i2p/router/networkdb/kademlia/FloodOnlySearchJob.java

into several, one class per file. I have to do it each time I upgrade the internal router in iMule, and this would be great if it was like this in the monotone repository !

Subtickets

Attachments (1)

SearchReplyJob.java (6.0 KB) - added by anonymous 11 years ago.

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by anonymous

Attachment: SearchReplyJob.java added

comment:1 in reply to:  description Changed 11 years ago by zzz

Owner: set to zzz
Status: newassigned

Replying to mkvore:

I'm on it

comment:2 Changed 11 years ago by anonymous

thanks zzz.
I finally managed compiling 0.6.5 in iMule, and I've noted all classes I had to put in their own file. I missed some :

class namecurrent file (rooted in router/java/src/net/i2p/router/)
SearchReplyJobnetworkdb/kademlia/SearchJob.java
ReplyVerifiedJobnetworkdb/kademlia/SearchJob.java
ReplyNotVerifiedJobnetworkdb/kademlia/SearchJob.java
FloodOnlyLookupTimeoutJobnetworkdb/kademlia/FloodOnlySearchJob.java
FloodOnlyLookupMatchJobnetworkdb/kademlia/FloodOnlySearchJob.java
FloodOnlyLookupSelectornetworkdb/kademlia/FloodOnlySearchJob.java
SingleLookupJobnetworkdb/kademlia/FloodOnlySearchJob.java
SingleSearchJobnetworkdb/kademlia/FloodOnlySearchJob.java
DummyClientManagerFacadeClientManagerFacade.java
DummyTunnelManagerFacadeTunnelManagerFacade.java
DummyCommSystemFacadeCommSystemFacade.java
OnRepublishSuccessnetworkdb/kademlia/RepublishLeaseSetJob.java
OnRepublishFailurenetworkdb/kademlia/RepublishLeaseSetJob.java
DummyPeerManagerFacadePeerManagerFacade.java
PersistProfileJobpeermanager/PersistProfilesJob.java

comment:3 Changed 11 years ago by zzz

thx for the list. Darn, I thought I was done.
I split out SearchJob? and FloodOnlySearchJob?, they are checked in 0.6.5-4.
Now to do the rest. Some I may just make private inner classes instead of splitting.

comment:4 Changed 11 years ago by zzz

done in i2p.i2p.zzz.test, will be in next propagate

comment:5 Changed 11 years ago by zzz

Resolution: fixed
Status: assignedclosed

propagated

Note: See TracTickets for help on using tickets.