Opened 6 years ago

Closed 5 years ago

#1202 closed defect (fixed)

Android jni ndk build is outdated

Reported by: nextloop Owned by: zzz
Priority: minor Milestone: 0.9.12
Component: apps/android Version: 0.9.11
Keywords: Cc: str4d
Parent Tickets: Sensitive: no

Description

patch is attached!
It should now compile again with ndk r9b and r9c.

Subtickets

Attachments (1)

patch.txt (445 bytes) - added by nextloop 6 years ago.

Download all attachments as: .zip

Change History (9)

Changed 6 years ago by nextloop

Attachment: patch.txt added

comment:1 Changed 6 years ago by nextloop

Please manually patch the patch.txt change line 10 from
+export AABI="arm-linux-androideabi-4.8"
to
+export AABI="arm-linux-androideabi-4.6"

i ran into assembler errors with 4.8. thanks!

comment:2 Changed 6 years ago by zzz

Component: otherapps/android
Owner: set to zzz

comment:3 Changed 5 years ago by zzz

<nextloop> to the f-droid out of date thing: i am waiting currently that a patch i already put in trac will be merged, after that, i can build android app again probably. i don't know how long this takes, maybe i can release it together with str4d_afk 's new UI

News to me, didn't know you were waiting (presumably for this ticket?) and this ticket is marked as priority minor.

Who do you think is working on it? Not me atm.

Please confirm that your change is tested and working on an API 8 (Froyo) device and that your patch is final.

comment:4 Changed 5 years ago by nextloop

please wait, did not test on my device yet. i do not have much time for this anyway at the moment.
i will comment again when enough tested!

comment:5 Changed 5 years ago by zzz

Status: newaccepted

OK, what I didn't realize until I started working on this is that the 4.4.3 → 4.6 change is the GCC version, not an ABI change. GCC 4.4.3 support was removed in NDK r9b. So the change should be fine. Still need to test though.

Making other cleanups to build.sh while I'm at it.

comment:6 Changed 5 years ago by zzz

Status: acceptedtesting

Fixed in 308f71ffe3cd95127aa1d73a0450f428f1d79344

With other cleanups and changes in routerjars/jni/build.sh also. Please test.

I did not replace the checked-in 4.4.3 libjbigi.so with the new 4.6 version, as there's no need. The 4.6 version will presumably be tested by nextloop in the F-Droid build.

I would guess you're patching build.sh anyway in F-Droid? If you need other changes to make things easier, let us know.

comment:7 Changed 5 years ago by nextloop

I tested it on my device and runs well! Router is up for over 30 minutes now.
Yes. I have to patch the build.sh to get the ndk dir set. An improvement would be to get the NDK dir from ./routerjars/local.properties . CustomRules?.xml could pass the path to build.sh as a parameter then.

comment:8 Changed 5 years ago by zzz

Resolution: fixed
Status: testingclosed

Closing, assuming success.

Note: See TracTickets for help on using tickets.