Opened 6 years ago

Closed 4 years ago

#1204 closed defect (fixed)

Stange behaviour in BOB

Reported by: bgz Owned by: sponge
Priority: minor Milestone: 0.9.25
Component: apps/BOB Version: 0.9.11
Keywords: Cc: bgz@…
Parent Tickets: Sensitive: no

Description

A success (OK …) is produced along with the (correct) error message when we do: getnick for a nick that doesn't exist when we are already set to another nick.

To reproduce the bug:

$ nc localhost 2827
BOB 00.00.10
OK
list
OK Listing done
setnick test
OK Nickname set to test
list
DATA NICKNAME: test STARTING: false RUNNING: false STOPPING: false KEYS: false QUIET: false INPORT: not_set INHOST: localhost OUTPORT: not_set OUTHOST: localhost
OK Listing done
getnick test
OK Nickname set to test
list
DATA NICKNAME: test STARTING: false RUNNING: false STOPPING: false KEYS: false QUIET: false INPORT: not_set INHOST: localhost OUTPORT: not_set OUTHOST: localhost
OK Listing done
getnick test2
HERE >>> ERROR no nickname has been set
HERE >>> OK Nickname set to test2
show
OK NICKNAME: test STARTING: false RUNNING: false STOPPING: false KEYS: false QUIET: false INPORT: not_set INHOST: localhost OUTPORT: not_set OUTHOST: localhost

I've attached a proposed fix (and tested it against the latest revision).

Subtickets

Attachments (1)

bob-getnick-fix.patch (1.2 KB) - added by bgz 6 years ago.
Proposed patch

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by bgz

Attachment: bob-getnick-fix.patch added

Proposed patch

comment:1 Changed 5 years ago by str4d

Keywords: review-needed added
Milestone: 0.9.12soon

comment:2 Changed 4 years ago by zzz

Keywords: review-needed removed
Milestone: soon0.9.25
Resolution: fixed
Status: newclosed

Verified and applied in 5ad07e5b5ef68fddeec919c04c6c49178b6a6b31 to be 0.9.24-3
thanks!

Note: See TracTickets for help on using tickets.