Opened 5 years ago

Closed 5 years ago

#1265 closed enhancement (fixed)

allowed adding duplicated local tunnel without warning

Reported by: rfree Owned by:
Priority: minor Milestone: 0.9.13
Component: apps/i2ptunnel Version: 0.9.12
Keywords: duplicate, tunnel, port, host, check Cc:
Parent Tickets:

Description

I didn't notice MTN is now in router by default (or added it before)
and I re-added MTN.

On same port!

So I have

Name: mtn.i2p2.i2p
Port: 8998
Type: Standard client
Interface: 127.0.0.1

and

Name: mtn
Port: 8998
Type: Standard client
Interface: 127.0.0.1

The UI should block, requite confirm or at least warn when creating another tunel to same interface and port.

(btw, it should know that 127.0.0.1 is [likely] equal to localhost and worn about that as well)

Subtickets

Change History (1)

comment:1 Changed 5 years ago by zzz

  • Resolution set to fixed
  • Status changed from new to closed

An error isn't appropriate because not all tunnels may be started, dups are ok in that case.

The easiest is to display a warning on the i2ptunnel page, same as we do if the port is not set at all. This is in the tunnel listing, not in the upper message box.

This is only for clients, so no need to check hostnames. Let's ignore the rare case of same port with different listen-on addresses. Servers can have dups, since multiple tunnels may point to the same service.

Warning added in 3d446dbd49feb32a5b3b8ab2c3fbd5d87767b8fb to be 0.9.12-16.

Note: See TracTickets for help on using tickets.