Opened 4 years ago

Closed 12 months ago

Last modified 12 months ago

#1433 closed task (fixed)

Implement notes in I2P addressbook

Reported by: djjeshk Owned by:
Priority: minor Milestone: 0.9.35
Component: apps/susidns Version: 0.9.17
Keywords: easy medium Cc:
Parent Tickets:

Description

Since addressbook has Notes entry, someone would implement or remove it.

Subtickets

Change History (8)

comment:1 Changed 4 years ago by djjeshk

  • Component changed from unspecified to apps/susidns

comment:2 Changed 4 years ago by zzz

  • Keywords easy medium added
  • Milestone changed from 0.9.18 to eventually

Details page already has a form, and form handler is NamingServiceBean?.getMessages().

Not quite easy because probably need 3 buttons conditionally displayed - Add, Edit, Delete notes. Maybe with some fancy js it could be all on that page, rather than creating a separate edit page. Without js, the /configclients page in the console could be an example for clicking a button to display an edit box. But js may work better.

Separately, we could add a notes field to the i2ptunnel HTTPClient save page. The HTML is in I2PTunnelHTTPClient.writeHelperSaveForm() and the handler is in LocalHTTPServer.serveLocalFile(). This would be pretty easy. And may actually be more useful than the susidns part.

comment:3 Changed 3 years ago by zzz

At CCC in December I walked a new contributor through the steps required to implement this. Didn't write down his name and haven't heard from him since. If you're out there and working on this, let us know.

comment:4 Changed 2 years ago by slumlord

zzz: If you've still got notes of that discussion (or remember what those steps were) please do share them here. Thanks

comment:5 Changed 2 years ago by zzz

I don't have any notes. Would be easiest to help you in IRC.

comment:6 Changed 12 months ago by zzz

  • Milestone changed from eventually to 0.9.35
  • Resolution set to fixed
  • Status changed from new to closed

In 40285d19ded0a1b90b0e6bf43615c812475972c6 0.9.34-16

comment:7 Changed 12 months ago by Reportage

  • Resolution fixed deleted
  • Status changed from closed to reopened

The notes implementation is a step forward, but incomplete, which is why I'm reopening this bug.

  • No option to delete notes (deleting text from textarea and saving does nothing)
  • Date modified field is set to local time.. should be UTC

UPDATE: Appears that saving an empty textarea does reset the notes, so just displaying the modification date in UTC to standardize with console behavior needed.

Last edited 12 months ago by Reportage (previous) (diff)

comment:8 Changed 12 months ago by zzz

  • Resolution set to fixed
  • Status changed from reopened to closed

I did reproduce it, maybe it was flaky, but it's fixed for good now.
Local time zone is on purpose, both for added and modded fields. Consistency with other webapps can be addressed in #2016
Also hid notes and other fields in published book where they aren't supported.
In b75c6a943fc560fd5cb830be09f00021cd7c8051 to be 0.9.34-17

Last edited 12 months ago by zzz (previous) (diff)
Note: See TracTickets for help on using tickets.