Opened 6 years ago

Closed 21 months ago

#1654 closed enhancement (fixed)

Snark should clearly indicate if a torrent is completed/seeding even when reporting a Tracker Error

Reported by: somewon Owned by: zzz
Priority: minor Milestone: 0.9.23
Component: apps/i2psnark Version: 0.9.21
Keywords: Cc:
Parent Tickets: Sensitive: no


At the moment, a torrent in the state "Tracker Error" will not indicate the state of the download on the main interface page.

I'm not exactly sure how to fix this - perhaps split "Tracker Error" into three separate states, "Tracker Error (Seeding)", "Tracker Error (Stalled)", and "Tracker Error (Downloading)"? Or just add another very small column for "Complete?" that displays either a green check or a red X or something? Open to thoughts, but I think it would improve the program to indicate this state no matter what status a torrent is in.


Change History (6)

comment:1 Changed 5 years ago by zzz

The whole "tracker error" message isn't very helpful now that we have DHT… except in the case you forgot to register the torrent with the tracker.

Perhaps we can just remove it completely.

comment:2 Changed 5 years ago by user

Maybe only in case you forgot to register the torrent, you shoud get an error message?
so not if trtacker is just unreachable, but when it somehow returns "torrent not registered"- does it report that??
But even then, the icon should still indicate whether seeding or downloading (completed and stopped would not show that error).

comment:3 Changed 5 years ago by zzz

Not a complete fix, but in 0cb514cbb1bdef209294a3a97840b1c66672bef2 to be 0.9.22-6, only display "Tracker Error" if the torrent is running.

Previously (and still true), it only displayed "Tracker Error" if there were no connected peers.

Given these constraints, the other choices in your proposal (Seeding, Complete, Stalled) are still possible, but I'm not yet convinced. Will think about it.

comment:4 Changed 5 years ago by user

I don't understand.
Whne it is "Complete" or "Stopped", the torrent is not running. So why would you care about the tracker anyway? So, I thought tracker error can only occur with running torrent.
Since we have DHT and PEX, it should not be an issue if you have DHT peers and not be displayed then, unless, as you pointed out, the owner wants to use a tracker but forgot to register the .torrent file. Then he should be informed.
Thinking about it more, in contrast to my above comment, I think it may be helpful to see this message not only in cases where tracker rejects, but also when tracker is unreachable. This might give the user a hint about the tracker's reliability, and might influence his choice of tracker in the future?
Am just brainstorming.
I have no strong opinion on the matter.

comment:5 Changed 5 years ago by zzz

Right. We are agreeing. Only display tracker error if running and no peers.

comment:6 Changed 21 months ago by zzz

Milestone: soon0.9.23
Resolution: fixed
Sensitive: unset
Status: newclosed

I'm going to leave this the way it is now, declaring the partial fix as enough.

Note: See TracTickets for help on using tickets.