Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#1678 closed task (fixed)

enable imap in bote

Reported by: kay Owned by: str4d
Priority: major Milestone: 0.9.24
Component: apps/plugins Version: 0.9.22
Keywords: I2P-Bote imap Cc:
Parent Tickets:

Description

the imap server in bote can be enabled again when commons-logging is removed from the main i2p-instal lib (see second issue for more info)

The following needs to changed to enable imap again in bote:

--- a/src/main/java/i2p/bote/I2PBote.java
+++ b/src/main/java/i2p/bote/I2PBote.java
@@ -402,7 +402,7 @@ public class I2PBote implements NetworkStatusSource, EmailFolderManager, MailSen
         connectTask.start();
 
-        // TODO Fix log4j loading so IMAP can start
-        if (false && configuration.isImapEnabled())
+        if (configuration.isImapEnabled())
             startImap();
         if (configuration.isSmtpEnabled())
             startSmtp();
@@ -580,7 +580,7 @@ public class I2PBote implements NetworkStatusSource, EmailFolderManager, MailSen
         configuration.setImapEnabled(enabled);
         if (imapService==null || !imapService.isStarted()) {
-            // TODO Fix log4j loading so IMAP can start
-            if (false && enabled)
+            if (enabled)
                 startImap();
         }
         else if (imapService!=null && imapService.isStarted() && !enabled)

Subtickets

#1679: remove trouble causing commons-logging.jar from i2p install (blocks #1678)defectclosed
#1680: make imap in bote only bind the configured address and portdefectclosed

Change History (12)

comment:1 Changed 4 years ago by kay

the solution ticket: #1679

and I forgot one (important) thing:

the commons-logging.jar now has to be added to the plugin/lib folder,
as bote (i.e. the james protocol jar) needs it.

Changes to build-xml:

--- build.xml	eeb6796d8de8082eb10c417155df6214e2e517c5
+++ build.xml	dbdf16d64ec44c26b724afb02909321346548c4c
@@ -81,6 +81,7 @@
         <include name="commons-configuration-1.9.jar"/>
         <include name="commons-io-2.4.jar"/>
         <include name="commons-lang-2.6.jar"/>
+        <include name="commons-logging.jar" />
         <include name="james-server-filesystem-api-3.0.0-beta5-SNAPSHOT.jar"/>
         <include name="james-server-lifecycle-api-3.0.0-beta5-SNAPSHOT.jar"/>
         <include name="james-server-protocols-imap4-3.0.0-beta5-SNAPSHOT.jar"/>
@@ -105,7 +106,6 @@
         <pathelement location="${i2plib}/jasper-compiler.jar" />
         <pathelement location="${i2plib}/jasper-runtime.jar" />
         <pathelement location="${i2plib}/javax.servlet.jar" />
-        <pathelement location="${i2plib}/commons-logging.jar" />
         <pathelement location="${i2plib}/commons-el.jar" />
         <pathelement location="${i2plib}/jstl.jar" />
         <pathelement location="${i2plib}/standard.jar" />

Last edited 4 years ago by kay (previous) (diff)

comment:2 Changed 4 years ago by kay

  • Keywords needs_review added
  • Parent Tickets set to 1679

comment:3 Changed 4 years ago by kay

  • Status changed from new to testing

comment:4 Changed 4 years ago by kay

Last edited 4 years ago by kay (previous) (diff)

comment:5 Changed 4 years ago by str4d

  • Status changed from testing to needs_work

Please do not change tickets to testing until the fix has actually been implemented. As the description says, testing is for marking the ticket as resolved, fixed and could be closed. If the fix has not been implemented, this is incorrect.

comment:6 Changed 4 years ago by str4d

  • Milestone changed from undecided to eventually
  • Parent Tickets 1679 deleted
  • Type changed from defect to task

comment:7 Changed 4 years ago by str4d

Add a subticket #1679.

comment:8 Changed 4 years ago by str4d

Add a subticket #1680.

comment:9 Changed 3 years ago by str4d

  • Component changed from unspecified to apps/plugins
  • Keywords needs_review removed
  • Milestone changed from eventually to 0.9.24
  • Owner set to str4d
  • Status changed from needs_work to accepted

IMAP re-enabled in 37b4a2662fc18dd99d145b103b776ec5f46bfa28.

commons-logging from Apache James added in 7d9b74309d121eeb33cdeb5fb97992a84c9028b7.

comment:10 Changed 3 years ago by str4d

Mime4J 0.7.2 added to updates and installer in b3cb4594857f95d1f7c939e88075b9200b782753.

It appears that the particular Apache James dev build I picked included a newer Mime4J (0.8.0), but the server code had not been rewritten yet to work with it. Thus in addition to Commons Logging, I need to include Mime4J in updates until the next time I do a James update (and then for a few large updates afterwards). *sigh*

I also saw a NPE alongside the Mime4J errors, but have not seen it since I figured out how to enable debug logging. Unless it appears again, I will optimistically close this once #1679 is closed.

comment:11 Changed 3 years ago by kay

  • Resolution set to fixed
  • Status changed from accepted to closed

This could be closed now, I think.

comment:12 Changed 3 years ago by anonimal

Thanks, kay and str4d. I've been looking forward to this fix :)

Note: See TracTickets for help on using tickets.