Opened 4 years ago

Closed 4 years ago

#1680 closed defect (fixed)

make imap in bote only bind the configured address and port

Reported by: kay Owned by:
Priority: minor Milestone: 0.9.24
Component: apps/plugins Version: 0.9.22
Keywords: I2P-Bote imap Cc:
Parent Tickets: #1678 Sensitive: no

Description

when testing #1678 and #1679 I noticed that the imapserver also binds the default imap address on port 143 which caused a permission error and made my bote hang.

here is the fix:

--- a/src/main/java/i2p/bote/imap/ImapService.java
+++ b/src/main/java/i2p/bote/imap/ImapService.java
@@ -123,6 +123,8 @@ public class ImapService extends IMAPServer {
             // select strong cipher suites
             cfg.setProperty("tls.supportedCipherSuites.cipherSuite",
                     StrongTls.getRecommendedCipherSuites(s.getSupportedCipherSuites()));
+            // set address and port from config in order to avoid binding the default port.
+            cfg.setProperty("bind", configuration.getImapAddress() + ":" + configuration.getImapPort());
         } catch (IOException e) {
             log.error("Couldn't determine supported cipher suites", e);
         } finally {
@@ -133,8 +135,6 @@ public class ImapService extends IMAPServer {
         }
         configure(cfg);   // use the defaults for the rest
 
-        setListenAddresses(new InetSocketAddress(configuration.getImapAddress(), configuration.getImapPort()));
-
         mailboxSessionMapperFactory = new MapperFactory(folderManager);
         MailboxACLResolver aclResolver = createMailboxACLResolver();
         GroupMembershipResolver groupMembershipResolver = new GroupMembershipResolver() {

Subtickets

Change History (5)

comment:1 Changed 4 years ago by kay

Keywords: needs_review added

comment:2 Changed 4 years ago by kay

Status: newtesting

comment:3 Changed 4 years ago by str4d

Status: testingneeds_work

Please do not change tickets to testing until the fix has actually been implemented. As the description says, testing is for marking the ticket as resolved, fixed and could be closed. If the fix has not been implemented, this is incorrect.

comment:4 Changed 4 years ago by str4d

Parent Tickets: 16791678

comment:5 Changed 4 years ago by str4d

Keywords: needs_review removed
Milestone: undecided0.9.24
Resolution: fixed
Status: needs_workclosed

Fixed in 09503df3afa7b73ba88b2b67667cc81117274a24.

Note: See TracTickets for help on using tickets.