Opened 4 years ago

Last modified 2 years ago

#1753 assigned enhancement

A minor, but more inclusive, 'we're proud of this code' nit:

Reported by: PrivacyHawk Owned by: z3r0fox
Priority: minor Milestone: undecided
Component: installer Version: 0.9.24
Keywords: easy Cc:
Parent Tickets: Sensitive: no

Description

I had previously mentioned this 'issue' on #i2p-dev, but zzz requested I create a ticket.

When a user runs: java -jar i2pinstall_0.9.24.jar -console (or similar), they see:

Welcome to the installation of i2p 0.9.24!

The homepage is at: https://geti2p.net/

My suggestion, and preference, is that we change that to:

Our main project website, which contains extensive i2p documentation, is located at: https://geti2p.net/

PH

Subtickets

Change History (5)

comment:1 Changed 4 years ago by zzz

Component: unspecifiedinstaller
Keywords: easy added

comment:2 Changed 4 years ago by z3r0fox

Owner: set to z3r0fox
Status: newassigned

comment:3 Changed 4 years ago by zzz

<z3r0fox_> If the jar isn't signed, I guess if there's no licensing issues I could(?) extract, change and repack it. Otherwise, this ticket may not be worth the time
<zzz> actually, you'd only have to pull out the eng.xml and change the strings
<zzz> and put it next to ukr.xml
<zzz> because they are looked up by id
<zzz> as long as the replacement sentence also has the variable at the end


Discussion:

izpack translation format is xml files with ids. So unlike with po files, we can change the english text without breaking the translations, since they are looked up by id.

One wrinkle is that the translations aren't done with a parameter. So instead of "our website is at {0}", it's just "our website is at" and izpack presumably just appends the URL. So whatever you change it too must keep the URL at the end of the sentence. You could change it to "We are the best ever. You wouldn't believe it. For all our documentation please go to our fabulous website" and izpack would append the URL. All the translations would stay unchanged, and that's fine.

To do that, extract the eng.xml file from standalone-compiler.jar, change what you like, and put it next to ukr.xml. The top-level build.xml file will take eng.xml and ukr.xml and replace them in the jar as a part of the build process. no changes to build.xml needed.

That's my theory anyway. Didn't test.

comment:4 Changed 4 years ago by zzz

If we do want to update the translations (or get translations for new languages, I haven't looked to see what's missing if any), we'd have to get all of them onto transifex, which is probably a separate ticket.

comment:5 Changed 2 years ago by slumlord

I think this would a good update. Thanks for the suggestion, PrivacyHawk?.

Note: See TracTickets for help on using tickets.