Opened 2 years ago

Last modified 8 months ago

#1864 accepted defect

IzPack 5

Reported by: zzz Owned by: zzz
Priority: minor Milestone: 0.9.36
Component: installer Version: 0.9.27
Keywords: Cc: sadie, slumlord
Parent Tickets:

Description

Thought dead but finally had a first release a year ago and many more since.
install.xml would have to be migrated.

izpack-dist-5.0.10.jar is 25 MB but must install it first and then take what we need from the 57 jars in lib/ to replace the single 6 MB standalone-compiler.jar. But not clear what. We could also just remove the izpack jar from our source. See bottom of bin/compile for main class.

http://izpack.org/downloads/
https://izpack.atlassian.net/wiki/display/IZPACK/Upgrading+Existing+Installers+from+IzPack+4.x+to+5.0
https://groups.google.com/forum/#!forum/izpack-announce

Lots of work and not clear for what gain. Install panels look a little nicer but not radically different. Documentation for 5 seems lacking. Would take a while to determine the minimal set of jars required.

Subtickets (add)

Change History (9)

comment:1 Changed 9 months ago by zab

It might end up necessary to look into this because IzPack 4 seems to have problems recognizing 64-bit versions of Windows 10

comment:2 Changed 9 months ago by zab

Error message that shows in the wrapper console window:

wrapper  | --> Wrapper Started as Console
wrapper  | Java Service Wrapper Community Edition 32-bit 3.5.25
wrapper  |   Copyright (C) 1999-2014 Tanuki Software, Ltd. All Rights Reserved.
wrapper  |     http://wrapper.tanukisoftware.com
wrapper  |
wrapper  | Launching a JVM...
jvm 1    | WrapperManager: Initializing...
jvm 1    | WrapperManager:
jvm 1    | WrapperManager: WARNING - Unable to load the Wrapper''s native library 'wrapper.dll'.
jvm 1    | WrapperManager:           The file is located on the path at the following location but
jvm 1    | WrapperManager:           could not be loaded:
jvm 1    | WrapperManager:             C:\Users\zlatin.balevsky\i2p\lib\wrapper.dll
jvm 1    | WrapperManager:           Please verify that the file is both readable and executable by the
jvm 1    | WrapperManager:           current user and that the file has not been corrupted in any way.
jvm 1    | WrapperManager:           One common cause of this problem is running a 32-bit version
jvm 1    | WrapperManager:           of the Wrapper with a 64-bit version of Java, or vica versa.
jvm 1    | WrapperManager:           This is a 64-bit JVM.
jvm 1    | WrapperManager:           Reported cause:
jvm 1    | WrapperManager:             C:\Users\zlatin.balevsky\i2p\lib\wrapper.dll: Can't load IA 32-bit .dll on a AMD 64-bit platform
jvm 1    | WrapperManager:           System signals will not be handled correctly.

comment:3 Changed 9 months ago by zzz

Thanks.

So izpack does appear to be guessing wrong. See installer/install.xml.

If there's no easy fix via install.xml, we could look at patching izpack 4.3, or research whether it's fixed in izpack 5 to either backport it, or make the move to izpack 5 sooner than later.

We could also consider doing a 64-bit-only installer build and put on our download page, but that may be even more trouble, as people probably don't know or have an easy way to find out if their OS and java install are 32 or 64 bit.

If we do consider patching, we should compare the izpack code to what we do in net.i2p.util.SystemVersion? lines 53-63, not that our code is necessarily correct either.

comment:4 Changed 9 months ago by meeh

I got the same message, but in my case it was jbigi.dll it didn't manage to load. - That happened on the first launch after install. Starting a second time solved the issue and warning is gone.

comment:5 Changed 9 months ago by zzz

It's not izpack that is guessing wrong. The 32/64 logic is simply based on a Java System property.

I verified on Windows 10 that the property sun.arch.data.model=64 but it is installing the 32-bit wrapper.

Spent several hours getting IzPack? 5.1.2 working. It has the same problem.

This IzPack? issue may be related? https://izpack.atlassian.net/projects/IZPACK/issues/IZPACK-1614?filter=allopenissues

For some reason it seems the Java system properties aren't being picked up on Win 10. Works fine on linux.

Will check in IzPack? 5 support soon. Will not check in the 64 MB of izpack jars. Will make separate build targets for IzPack? 5, and you'll have to install izpack 5 separately.

comment:6 Changed 9 months ago by zzz

  • Owner set to zzz
  • Status changed from new to accepted

As above, in fbfd336fe47edc8f7c42a7015ab655329efc9458 to be 0.9.35-8

comment:7 Changed 9 months ago by zzz

  • Milestone changed from eventually to 0.9.36

Figured out the Windows 10 problem. System properties aren't initialized soon enough, so we need to use dynamicvariables. Fixed in both izpack 4 and 5, in dd98084f5e5333c408b6237053fd51621dc156e9 0.9.35-8.

Leaving ticket open for testing, and to decide whether to switch to IzPack? 5 for the release.

comment:8 Changed 9 months ago by zzz

Tickets filed:
https://izpack.atlassian.net/projects/IZPACK/issues/
IZPACK-1629
IZPACK-1630
IZPACK-1631

comment:9 Changed 8 months ago by zzz

  • Cc sadie slumlord added

When moving to IzPack? 5 we may also consider changing/improving any number of things:

  • Changing themes (can be different for Windows and Linux)
  • Changing any text
  • Adding translations for untranslated text, putting on transifex
  • Changing panel order
  • Changing images
  • Changing defaults
  • Fixing and/or disabling the uninstaller
  • Changing the labels on the windows desktop icons ("restartable" and "no window")
  • Adding desktop icons on linux

Guidance for much of this may come out of the usability testing and ongoing twitch tutorials; cc: sadie and slumlord for input.

IZPACK-1631 (console mode helper) may be a blocker to using IzPack? 5 on linux for now.

Note: See TracTickets for help on using tickets.