Opened 2 years ago

Closed 16 months ago

#1879 closed defect (fixed)

Move transport HTML methods to router console

Reported by: zzz Owned by: zzz
Priority: minor Milestone: 0.9.31
Component: router/transport Version: 0.9.27
Keywords: Cc: str4d
Parent Tickets:

Description

There's a large chunk of HTML generation code for /peers in NTCPTransport and UDPTransport (and associated Sorters.java) that shouldn't be in router.jar. Two reasons it's still there - it's a pain to extract it out, and Android uses it. UPnP HTML will probably stay behind. The HTML peers page in Android is ugly and doesn't match the rest of the UI anyway, so it will be an improvement to replace it. Main reason it was there was debugging, but users may miss it.

I'd like to do this for .29, but only if st4d agrees.

Subtickets

Change History (4)

comment:1 Changed 2 years ago by zzz

  • Milestone changed from 0.9.29 to 0.9.30
  • Status changed from new to open

str4d has agreed re: android, but to avoid merge hell, deferring until ui branch prop in .30
see also #1934

comment:2 Changed 2 years ago by zzz

  • Milestone changed from 0.9.30 to 0.9.31
  • Status changed from open to accepted

Deferring to .31 since ui prop was deferred.

comment:3 Changed 22 months ago by zzz

In 485f004a512fde968207195dba33d2c86e827566 0.9.30-6
UPnP HTML not yet moved, and may not be. Leaving open for now.

comment:4 Changed 16 months ago by zzz

  • Resolution set to fixed
  • Status changed from accepted to closed

Moving UPnP would be far more trouble than it's worth. Closing.

Note: See TracTickets for help on using tickets.