Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#1963 closed defect (fixed)

Reducing maxParticipatingTunnels turns off probability based tunnel rejection

Reported by: Mysterious Owned by: zzz
Priority: minor Milestone: 0.9.30
Component: router/general Version: 0.9.29
Keywords: Cc:
Parent Tickets: Sensitive: no

Description (last modified by Mysterious)

There is a mechanism in place that intends to disable probability based tunnel rejection when the maximum number of tunnels is increased above default, it insteads works the wrong way around.

(Example) patch coming very soon.

Subtickets

Change History (6)

comment:1 Changed 2 years ago by Mysterious

Component: unspecifiedrouter/general

comment:2 Changed 2 years ago by Mysterious

Description: modified (diff)

comment:3 Changed 2 years ago by Mysterious

Please check this blog post for patch: http://mysterious.i2p/blog/poking-into-the-i2p-router.html

comment:4 Changed 2 years ago by Mysterious

As promised the patches the directly affect this ticket:
http://p66g2a4nzfkvidd3l7nwphcnfa3ttyu5kiolcb4czec2rn2kvwsq.b32.i2p/assets/patches-06-03-2017/0003-RouterThrottleImpl-disable-instead-of-enable-tunnel-.patch

Please also check the blog for the cleanup patches 5 and 6.

comment:5 Changed 2 years ago by zzz

Owner: set to zzz
Status: newaccepted

This line came from the following change. The checkin comments match the in-line comment. Confirmed that the existing code doesn't match the stated intent.

Revision: c52409bf5d7b422c23a62eecfa50b98d7c74f8df
Date: 01/16/2012
Branch: i2p.i2p
Don't throttle tunnel creation if using a higher than default router.maxParticipatingTunnels setting.

Last edited 2 years ago by zzz (previous) (diff)

comment:6 Changed 2 years ago by zzz

Milestone: undecided0.9.30
Resolution: fixed
Status: acceptedclosed

Acked by hottuna in IRC.

In efee07c041c14d23e1ed1f27398672e67ca6f1c9 0.9.29-2

Note: See TracTickets for help on using tickets.