Server doesn't restart listening after soft restart

[zzz]

Tunnel is up and being published, all green in hidden svcs mgr, nothing in logs after restart until changed to WARN, where it's apparent incoming conns are being discarded. Server does not have an alternate non-DSA dest. logs in comment 1. Could be streaming or i2ptunnel issue.

[zzz]

xx/xx xx:30:58.027 CRIT  [nal Reader 1] net.i2p.util.Clock            : Large clock shift forward by 5m
xx/xx xx:31:01.381 ERROR [nal Reader 1] net.i2p.router.Router         : Restarting after large clock shift forward by 5m
xx/xx xx:31:03.979 ERROR [uter Restart] net.i2p.router.Router         : Stopping the router for a restart...
xx/xx xx:31:03.979 WARN  [uter Restart] net.i2p.router.Router         : Stopping the client manager
xx/xx xx:31:04.824 ERROR [l Reader 108] lient.impl.I2PSessionMuxedImpl: [OPEN shared clients #61296]: Error occurred communicating with router: Router restart
net.i2p.client.I2PSessionException: Disconnect Message received
	at net.i2p.client.impl.DisconnectMessageHandler.handleMessage(DisconnectMessageHandler.java:33)
	at net.i2p.client.impl.I2PSessionImpl.messageReceived(I2PSessionImpl.java:952)
	at net.i2p.internal.QueuedI2CPMessageReader$QueuedI2CPMessageReaderRunner.run2(QueuedI2CPMessageReader.java:56)
	at net.i2p.data.i2cp.I2CPMessageReader$I2CPMessageReaderRunner.run(I2CPMessageReader.java:164)
	at java.lang.Thread.run(Thread.java:745)
	at net.i2p.util.I2PThread.run(I2PThread.java:103)
xx/xx xx:31:04.856 ERROR [nal Reader 2] lient.impl.I2PSessionMuxedImpl: [OPEN example.i2p #63787]: Error occurred communicating with router: Router restart
net.i2p.client.I2PSessionException: Disconnect Message received
	at net.i2p.client.impl.DisconnectMessageHandler.handleMessage(DisconnectMessageHandler.java:33)
	at net.i2p.client.impl.I2PSessionImpl.messageReceived(I2PSessionImpl.java:952)
	at net.i2p.internal.QueuedI2CPMessageReader$QueuedI2CPMessageReaderRunner.run2(QueuedI2CPMessageReader.java:56)
	at net.i2p.data.i2cp.I2CPMessageReader$I2CPMessageReaderRunner.run(I2CPMessageReader.java:164)
	at java.lang.Thread.run(Thread.java:745)
	at net.i2p.util.I2PThread.run(I2PThread.java:103)
xx/xx xx:31:04.926 WARN  [uter Restart] net.i2p.router.Router         : Stopping the comm system
xx/xx xx:31:05.958 ERROR [7.0.0.1:xxxx] .i2ptunnel.I2PTunnelHTTPServer: Error accepting
java.net.ConnectException: ServerSocket closed
	at net.i2p.client.streaming.impl.ConnectionHandler.accept(ConnectionHandler.java:178)
	at net.i2p.client.streaming.impl.I2PSocketManagerFull.receiveSocket(I2PSocketManagerFull.java:358)
	at net.i2p.client.streaming.impl.I2PServerSocketFull.accept(I2PServerSocketFull.java:38)
	at net.i2p.i2ptunnel.I2PTunnelServer.run(I2PTunnelServer.java:555)
	at java.lang.Thread.run(Thread.java:745)
	at net.i2p.util.I2PThread.run(I2PThread.java:103)
xx/xx xx:31:15.609 WARN  [uter Restart] net.i2p.router.Router         : Stopping the tunnel manager
xx/xx xx:31:15.751 WARN  [uter Restart] net.i2p.router.Router         : Router teardown complete, restarting the router...
xx/xx xx:31:25.584 ERROR [d clients]: ] lient.impl.I2PSessionMuxedImpl: [CLOSED shared clients]: Error reconnecting on attempt 1
net.i2p.client.I2PSessionException: Router client manager is shut down
	at net.i2p.router.client.ClientManager.internalConnect(ClientManager.java:211)
	at net.i2p.router.client.ClientManagerFacadeImpl.connect(ClientManagerFacadeImpl.java:265)
	at net.i2p.client.impl.I2PSessionImpl.connect(I2PSessionImpl.java:610)
	at net.i2p.client.impl.I2PSessionImpl.reconnect(I2PSessionImpl.java:1324)
	at net.i2p.client.impl.I2PSessionImpl2.reconnect(I2PSessionImpl2.java:490)
	at net.i2p.client.impl.DisconnectMessageHandler$Reconnector.run(DisconnectMessageHandler.java:51)
	at java.lang.Thread.run(Thread.java:745)
	at net.i2p.util.I2PThread.run(I2PThread.java:103)
xx/xx xx:31:25.756 WARN  [uter Restart] net.i2p.router.Router         : Restarting the comm system
xx/xx xx:31:25.757 WARN  [uter Restart] net.i2p.router.Router         : Restarting the tunnel manager
xx/xx xx:31:25.757 WARN  [uter Restart] net.i2p.router.Router         : Restarting the client manager
xx/xx xx:31:27.088 WARN  [uter Restart] net.i2p.router.Router         : Restart complete
xx/xx xx:32:37.925 ERROR [leTimer2 2/2] lient.impl.I2PSessionMuxedImpl: [OPEN example.i2p #54598]:  Client not responding? Message not processed! id=6226573: [MessagePayloadMessage: 
	SessionId: 54598
	MessageId: 6226573
	Payload: [Payload: 782 bytes]]

... after setting level to WARN ...

xx/xx xx:26:58.735 WARN  [2p #54598]: ] reaming.impl.ConnectionHandler: Dropping non-SYN packet - not listening
xx/xx xx:28:56.460 WARN  [2p #54598]: ] reaming.impl.ConnectionHandler: Dropping new SYN request, as we're not listening

[slumlord]

I've had routers fail to return after a 'graceful restart', not sure if it is related. I'll keep this ticket in mind if I see that happen again.

[zzz]

notes:

I2PTunnelServer thread gets a ConnectException? at line 555 in accept() and exits.
This change was made 2014-11-13; previously it would sleep and then loop.
However at lower level, streaming/i2cp reconnects, but with no accept?
I think we need a retry in i2ptunnel but that could mess up a real shutdown.
May need to rethink soft restart and whether we tell the clients at all.
This is messy.

[zzz]

In a71c7860f4b43e0bc060456a00e4652f5f078255 0.9.33-7