Opened 4 years ago

Last modified 4 years ago

#2171 accepted task

Migrate to the library version of EdDSA-Java

Reported by: str4d Owned by: str4d
Priority: minor Milestone: 0.9.34
Component: package/maven Version: 0.9.33
Keywords: cleanup Cc:
Parent Tickets: Sensitive: no


The EdDSA-Java library was developed outside I2P and then pulled into the core codebase. However, the packages are identical, so a third party wanting to depend on both i2p.jar and some other package that depends on eddsa-java.jar will need to do more complex package exclusions in order to get things working.

We should not bundle net.i2p.crypto.eddsa inside the i2p.jar published on Maven Central, and instead add a dependency on net.i2p.crypto:eddsa. The i2p.jar bundled within the router itself should probably continue to contain that code for now, but we should also think about fixing this in future (e.g. if we start using the Gradle scripts for packaging, then pulling in external dependencies is trivial).


Change History (2)

comment:1 Changed 4 years ago by str4d

Owner: set to str4d
Status: newaccepted

comment:2 Changed 4 years ago by zzz

Component: api/cryptopackage/maven
Milestone: undecided0.9.34

Should be a simple change for Maven, and we already have other dependencies, should be easy. Changing component and setting for .34 for now, but your call ofc.

Note: See TracTickets for help on using tickets.