Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2204 closed enhancement (fixed)

Patch to add a 'Built By' field to /logs

Reported by: slumlord Owned by: str4d
Priority: minor Milestone: 0.9.35
Component: apps/console Version: 0.9.33
Keywords: console, built-by, debug Cc:
Parent Tickets: Sensitive: no


As discussed at 34C3, and online afterwards, I think it would be useful to have a 'Built By' field on the /logs page. It would be useful when working on tickets to know the source of the installation files (provided that it is defined in the file as a build.built-by=STRING at build time). For example, if there are problems with the build system at bobthebuilder.i2p that are causing errors after installation, the information about the source of the files would be available immediately.


Attachments (1)

built-by.patch (3.7 KB) - added by slumlord 3 years ago.
Patch to add a 'Built By' field to the /logs page

Download all attachments as: .zip

Change History (3)

Changed 3 years ago by slumlord

Attachment: built-by.patch added

Patch to add a 'Built By' field to the /logs page

comment:1 Changed 3 years ago by zzz

Resolution: fixed
Status: newclosed

In 8c04408c95d5f4e60db84476959d6b7d7d3911ff to be 0.9.34-2
changes from patch above:

  • made methods package private
  • removed trailing / from lib
  • added javadocs
  • handled null return from attributes()
  • remove debug println

please review to see if the changes look ok.

There's no caching of the value - we'll pull it out of i2p.jar on every load of /logs. It doesn't appear to slow things down. If we do want to cache it, it would be straightforward to store the value in a static field, inside a sync block. But this looks good for now.

comment:2 Changed 3 years ago by zzz

Milestone: undecided0.9.35

measured as approx. 1 ms, no need for caching

Note: See TracTickets for help on using tickets.