#2242 closed defect (fixed)

CSS issues with Susimail and Dark theme - Folder Navigation button and drop-down have no text

Reported by: slumlord Owned by: zzz
Priority: minor Milestone: 0.9.35
Component: apps/susimail Version: 0.9.34
Keywords: webmail, dark, theme Cc:
Parent Tickets: Sensitive: no

Description

Please see screenshot.

On the dark theme, the folder navigation button and the drop-down folder selector have no text inside them.

Subtickets

Attachments (1)

susimail.png (27.5 KB) - added by slumlord 15 months ago.
Susimail with dark theme - CSS causes missing text for foloder selection button and drop-down

Download all attachments as: .zip

Change History (6)

Changed 15 months ago by slumlord

Attachment: susimail.png added

Susimail with dark theme - CSS causes missing text for foloder selection button and drop-down

comment:1 Changed 15 months ago by slumlord

Status: newtesting

Changes in 792754a7d8ce5d77477030dc0e2cc51945d6f3d4

Changing status to testing

comment:2 Changed 15 months ago by zzz

Milestone: undecided0.9.35

good catch, I hadn't tested the other themes, I'll do that shortly

comment:3 Changed 15 months ago by zzz

Status: testingneeds_work

input.switchto (the button) didn't change for me. it did fix the dropdown.
It appears that I added things to the other 3 themes, but not to the dark one, because it's different from the others.
The fix needs explicit input.switchto and input.moveto settings in the CSS. I don't believe that commenting things out will fix it.

comment:4 Changed 15 months ago by zzz

In the dark theme, the text on buttons is disabled in the CSS (presumably on purpose… font-size: 0)

Assuming we don't want to change that decision, at least for now, the fix for dark is not to re-enable the text, but to add a folder icon so the button has something in it. Commenting out the font-size: 0 causes havoc in the other buttons.

comment:5 Changed 15 months ago by zzz

Resolution: fixed
Status: needs_workclosed

Revert comment 1 change, fix up as described in comment 4, also tweak the alignment in midnight theme
in c42889e5ef170969c0487cf8785391af34564d8b to be 0.9.34-21-rc
Dropdown box size and font still a little wonky in all three non-default themes, but good enough for now.

Note: See TracTickets for help on using tickets.