Opened 3 years ago

Closed 3 years ago

#2272 closed task (fixed)

Reduce themes

Reported by: zzz Owned by: zzz
Priority: minor Milestone: 0.9.39
Component: apps/console Version: 0.9.34
Keywords: Cc: sadie, slumlord, Alex, alex_wykoff
Parent Tickets: #2330 Sensitive: no


ref: http://i2pforum.i2p/viewtopic.php?f=32&t=299
Probably classic and midnight.
In CSSHelper.getTheme(), map classic to light and midnight to dark.
In ConfugUIHelper.themeSet(), skip the themes.
Forks retaining these themes would have to either rename the themes or remove the new mapping/skipping code.
Similar changes in each themed webapp.
Pending guidance from UI strategy team.


Change History (9)

comment:1 Changed 3 years ago by zzz

Cc: sadie slumlord added
Status: newaccepted

Prelim. code to map midnight to dark and classic to light, disabled for now, in a160bff05187c71cb219db90acb74f3d437d784a to be 0.9.35-19

comment:2 Changed 3 years ago by zzz

Milestone: 0.9.360.9.37

comment:3 Changed 3 years ago by slumlord

Related ticket/comment: http://trac.i2p2.i2p/ticket/2302#comment:2

Suggest replacing icons for Shutdown/Restart? buttons with text as it would be translatable, instead of hoping that the meaning of the icons is well understood by users.

comment:4 Changed 3 years ago by zzz

Milestone: 0.9.370.9.38

comment:5 Changed 3 years ago by zzz

Parent Tickets: 2330

comment:6 Changed 3 years ago by sadie

As we are updating our iconography, we will hopefully be able to address this in .38. Should that not happen, replacing the shutdown button from the restart button would be a good minor fix.

comment:7 Changed 3 years ago by zzz

As soon as I get the first CSS or themed icon changes from the design team, I will remove the midnight and classic themes. As I understand it, this will be by early to mid December.

comment:8 Changed 3 years ago by zzz

Cc: Alex alex_wykoff added
Milestone: 0.9.380.9.39

Pushed to 39 as decided at 2018-12-29 meeting

comment:9 Changed 3 years ago by zzz

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.