Opened 3 years ago

Closed 2 years ago

#2333 closed defect (fixed)

some classpath for testing with ant is missing javac.classpath

Reported by: tharvik Owned by: zzz
Priority: minor Milestone: 0.9.39
Component: package/other Version: 0.9.37
Keywords: ant test Cc:
Parent Tickets: Sensitive: no


Currently, the classpath used for compiling junit tests is using hamcrest.home and junit.home. It is redefined in every javac task.
In core/java/build.xml, junit.compileTest also contains <pathelement path="${javac.classpath}" />, which allows for custom classpath to be given (used when the hamcrest jars are not placed in the same directory for example). Sadly, it isn't added to the others junit.compileTest.
As such, it is not possible to run the tests on Gentoo.
Simply adding the pathelement to the others tasks allows it to compile.


Change History (5)

comment:1 Changed 3 years ago by zzz

Component: unspecifiedpackage/other
Milestone: undecided0.9.38
Owner: set to zzz
Status: newaccepted

comment:2 Changed 3 years ago by zzz

Resolution: fixed
Status: acceptedclosed

Added javac.classpath to junit.compileTest targets in router, ministreaming, and streaming.
In 1455311d4a37b7d527c7e45ec35212d433e0a936 0.9.37-2

comment:3 Changed 2 years ago by tharvik

Resolution: fixed
Status: closedreopened

Hum, the patch is slightly wrong, you've used <pathelement location="${javac.classpath}" /> but it's not a location, it's a path: it's colon separated, indicating multiple location. Currently, one can only select one jar with it.

comment:4 Changed 2 years ago by zzz

Milestone: 0.9.380.9.39

ok, thought i followed the instructions in the OP on what you wanted, but didn't think about it too hard. Will try again.

comment:5 Changed 2 years ago by zzz

Resolution: fixed
Status: reopenedclosed

yeah, my mistake
fixed in 7108a480a16fac06f514a5e725e36ec326b6a62e 0.9.38-3

Note: See TracTickets for help on using tickets.