Opened 7 months ago

Closed 3 months ago

#2333 closed defect (fixed)

some classpath for testing with ant is missing javac.classpath

Reported by: tharvik Owned by: zzz
Priority: minor Milestone: 0.9.39
Component: package/other Version: 0.9.37
Keywords: ant test Cc:
Parent Tickets:

Description

Currently, the classpath used for compiling junit tests is using hamcrest.home and junit.home. It is redefined in every javac task.
In core/java/build.xml, junit.compileTest also contains <pathelement path="${javac.classpath}" />, which allows for custom classpath to be given (used when the hamcrest jars are not placed in the same directory for example). Sadly, it isn't added to the others junit.compileTest.
As such, it is not possible to run the tests on Gentoo.
Simply adding the pathelement to the others tasks allows it to compile.

Subtickets

Change History (5)

comment:1 Changed 6 months ago by zzz

  • Component changed from unspecified to package/other
  • Milestone changed from undecided to 0.9.38
  • Owner set to zzz
  • Status changed from new to accepted

comment:2 Changed 6 months ago by zzz

  • Resolution set to fixed
  • Status changed from accepted to closed

Added javac.classpath to junit.compileTest targets in router, ministreaming, and streaming.
In 1455311d4a37b7d527c7e45ec35212d433e0a936 0.9.37-2

comment:3 Changed 3 months ago by tharvik

  • Resolution fixed deleted
  • Status changed from closed to reopened

Hum, the patch is slightly wrong, you've used <pathelement location="${javac.classpath}" /> but it's not a location, it's a path: it's colon separated, indicating multiple location. Currently, one can only select one jar with it.

comment:4 Changed 3 months ago by zzz

  • Milestone changed from 0.9.38 to 0.9.39

ok, thought i followed the instructions in the OP on what you wanted, but didn't think about it too hard. Will try again.

comment:5 Changed 3 months ago by zzz

  • Resolution set to fixed
  • Status changed from reopened to closed

yeah, my mistake
fixed in 7108a480a16fac06f514a5e725e36ec326b6a62e 0.9.38-3

Note: See TracTickets for help on using tickets.