Opened 13 months ago

Closed 12 months ago

#2383 closed enhancement (fixed)

Skip useless calls to now() in PacketHandler.java

Reported by: jogger Owned by: zzz
Priority: minor Milestone: 0.9.39
Component: router/transport Version: 0.9.37
Keywords: Cc: Zlatin Balevsky
Parent Tickets: Sensitive: no

Description

From void run()

long queueTime = packet.getLifetime();
long handleStart = _context.clock().now();
long handleTime = _context.clock().now() - handleStart;

Subtickets

Change History (3)

comment:1 Changed 13 months ago by Zlatin Balevsky

Cc: Zlatin Balevsky added
Component: unspecified → router/transport
Owner: set to zzz
Type: defect → enhancement

comment:2 Changed 12 months ago by jogger

Just looked at 0.9.38. Strictly speaking they are useless because they are used for some RateData? that is used nowhere. Meanwhile found many, many places where clock().now() is (in-)directly called for RateData? that gets never used. And even most of the required ones are only used for display on the stats page.

comment:3 Changed 12 months ago by zzz

Milestone: undecided → 0.9.39
Resolution: → fixed
Status: new → closed

In ab1409db90cb6889a2df8f52c85ad529ddc3ba5c to be 0.9.38-7

Note: See TracTickets for help on using tickets.