Opened 11 months ago

Closed 8 months ago

#2403 closed defect (fixed)

Signing corrupts the windows installer

Reported by: Zlatin Balevsky Owned by:
Priority: minor Milestone: 0.9.40
Component: installer Version: 0.9.38
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

Signing the windows installer with signtool causes the installer to become corrupt. Possible solution outlined here https://stackoverflow.com/questions/22325009/sign-a-launch4j-executable-in-ant-with-sign4j-and-jsign but that would require either building the installer on a windows machine, and I'm not sure signtool can be invoked outside of a developer command prompt.

Other options include:

  • leave the windows installer unsigned
  • move away from launch4j, either via izpack's binary or jlink (i2p-zero)

Subtickets

Change History (2)

comment:1 Changed 11 months ago by zzz

Milestone: undecided0.9.39

Would be nice to figure this out for 39, but will take some time to research and test the options.

I've never looked closely at the izpack exe tools (on either izpack 4 or 5), launch4j was in place before my time, 15 years ago.

comment:2 Changed 8 months ago by zzz

Milestone: 0.9.390.9.40
Resolution: fixed
Status: newclosed

Switched releases to use IzPack5 tools in 7b304521198bd6cf1f6d662d79376c4a5ec59691 to be 0.9.40.
It's too big to bundle, so users can install IzPack? (tested with 5.1.3) and then use the installer5 or installer5-windows targets, as checked in 10 months ago. But I doubt users are signing exe files.
Or, use standard build targets to use IzPack? 4 which is still bundled. No plans to remove it at this point.

Note: See TracTickets for help on using tickets.