I2PSnark-Standalone: BlockfileNamingService

[lg]

Source: i2psnark-standalone-c216dcd9af.zip-SHA256-ed38d4dea96d (​http://bobthebuilder.i2p/)

30.03.19, 13:50:32 ERROR    [dQ%c1O%08 #1] 2p.client.naming.NamingService: Cannot load naming service net.i2p.router.naming.BlockfileNamingService, using HostsTxtNamingService
java.lang.ClassNotFoundException: net.i2p.router.naming.BlockfileNamingService
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583)
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:315)
        at net.i2p.client.naming.NamingService.createInstance(NamingService.java:760)
        at net.i2p.I2PAppContext.initializeNamingService(I2PAppContext.java:654)
        at net.i2p.I2PAppContext.namingService(I2PAppContext.java:647)
        at net.i2p.util.ConvertToHash.getHash(ConvertToHash.java:79)
        at org.klomp.snark.TrackerClient.getHostHash(TrackerClient.java:926)
        at org.klomp.snark.TrackerClient.isNewValidTracker(TrackerClient.java:366)
        at org.klomp.snark.TrackerClient.setup(TrackerClient.java:289)
        at org.klomp.snark.TrackerClient.run(TrackerClient.java:241)
        at java.base/java.lang.Thread.run(Thread.java:834)
        at net.i2p.util.I2PThread.run(I2PThread.java:103)

[zzz]

BlockfileNamingService? was moved from i2p.jar to addressbook.jar in 0.9.31, a year and a half ago, but the snark standalone build does not bundle the classes from addressbook.jar. I believe that this application doesn't need the blockfile naming service, as there's no susidns UI or subscriptions set up.

But I don't see why it thinks it's in RouterContext?. A config file issue? To be investigated.

In any case, minor issue, as it's falling back to hosts.txt naming service.

[zzz]

Reproduced/fixed/tested here.
The class selection in app context was wrong.
In 5b528cad5cd19238bf3d33d566c68508604f6bce to be 0.9.39-6