Opened 21 months ago
Last modified 21 months ago
#2526 assigned defect
change ssl port from 4444 to 4445
Reported by: | anonymous maybe | Owned by: | Meeh |
---|---|---|---|
Priority: | minor | Milestone: | undecided |
Component: | apps/browser | Version: | 0.9.40 |
Keywords: | Cc: | idk | |
Parent Tickets: | Sensitive: | no |
Description
title is enough
Subtickets
Change History (13)
comment:1 Changed 21 months ago by
Cc: | idk added |
---|
comment:2 Changed 21 months ago by
Owner: | changed from Meeh to idk |
---|---|
Status: | new → assigned |
comment:3 Changed 21 months ago by
comment:4 Changed 21 months ago by
The file is edited by me in all my branches of the browser, so easy to find - a good first task for someone else than me
comment:5 Changed 21 months ago by
The proxy at port 4444 supports SSL. An SSL-only proxy at port 4445 is a very old setup and is not the default. I don't think you want to do this.
comment:6 Changed 21 months ago by
The latest browser already fixed this issue, but zzz whats the point of having 2 tunnels if both acting the same thing ? and if the browser only browsing through tunnel 127.0.0.1:4444 then 4445 would useless to it.
so if 4445 not used , should it be deleted from I2Pconsole or whats the point being there i dont get it.
comment:7 Changed 21 months ago by
I suspect two tunnels are legacy. Before I took over the outproxy I think you actually had to use the other one cause the first one forced plaintext http in the software at the other end.
At least after I took over, I started setting things up so that it wouldn't matter at least from my end as the outproxy, so people could use both.
comment:8 Changed 21 months ago by
And currently, the browser is still wrong - it's just overruled/overwritten by i2pbutton all the time :p
comment:9 Changed 21 months ago by
I see the best things simple and straight forward , if one tunnel can handle everything and the second tunnel just sitting there has nothing to do then its better to deprecate it. but if its useful for something like separating connections or so then thats something else.
comment:10 follow-up: 11 Changed 21 months ago by
Owner: | changed from idk to Meeh |
---|---|
Priority: | major → minor |
SSL (aka CONNECT) proxying was originally implemented in a separate tunnel type with default port 4445 in early 2009, as this was the most straightforward development path at the time.
CONNECT support was added to the HTTP proxy on port 4444 in early 2014.
There's no good reason to remove the CONNECT tunnel as an option, it's there if somebody needs it. It's not enabled by default for new installs.
comment:11 Changed 21 months ago by
Sensitive: | unset |
---|
Replying to zzz:
SSL (aka CONNECT) proxying was originally implemented in a separate tunnel type with default port 4445 in early 2009, as this was the most straightforward development path at the time.
CONNECT support was added to the HTTP proxy on port 4444 in early 2014.
There's no good reason to remove the CONNECT tunnel as an option, it's there if somebody needs it. It's not enabled by default for new installs.
So in the browser if we tick "Use this proxy server for all protocols" as 127.0.0.1 with port 4444 that will do the same needed purpose?
comment:12 follow-up: 13 Changed 21 months ago by
That sounds right, but don't ask me about your browser settings, what do I know… you didn't even tell us what browser.
comment:13 Changed 21 months ago by
Replying to zzz:
That sounds right, but don't ask me about your browser settings, what do I know… you didn't even tell us what browser.
Aha thats great then.
I2P Browser what im using here.
This change would be then needed in browser/content/blabla-can't-remember/000-tor-browser.js and in the default preferences in i2pbutton https://github.com/mikalv/i2pbutton for this. Both places must be updated to ensure consistence between the different flavors and builds.