Orchid fails to download descriptors when useMicrodescriptors=false

[Reportage]

When useMicrodescriptors set to false, Orchid will repeatedly fail to download descriptors and will be unable to build circuits.

WARN […k worker-96] …toryDownloadTask: [Orchid] Failed to download router descriptors: Failed to parse response from Directory: Too many arguments for keyword 'extra-info-digest' expected 1 and got 2

Appears to be a modification to the spec that breaks Orchid.

More info:

• ​https://github.com/torproject/torspec/blob/master/dir-spec.txt
• ​https://trac.torproject.org/projects/tor/ticket/22034
• ​https://trac.torproject.org/projects/tor/ticket/16330
• ​https://gitweb.torproject.org/stem.git/commit/?id=ba8cee36a0348c1509ad3562051723b7948e19ce

Spec update:

• ​https://trac.torproject.org/projects/tor/ticket/21498
• ​https://github.com/torproject/torspec/commit/0f03581e748d4867a009d3d9473d61a400a3f5c1

[zzz]

Then don't set the value? Why would you do that? We don't provide any UI to change settings, so nobody's going to stumble into this. Arbitrary settings aren't guaranteed to work.

[Reportage]

Full descriptors are required to enable various functions listed in src/java/com/subgraph/orchid/Router.java

Specifically, I want to be able to expose router uptime, bandwidth, and platform information in the UI.

In terms of the size of the consensus files vs the microdesc-consensus, the difference is negligible, 2.2MB vs 2MB, so enabling their use shouldn't noticeably impact performance.

[Reportage]

Workaround:

@@ public class DocumentFieldParserImpl imp
 
 			// Is this the correct thing to do, or should just be a warning?
-			throw new TorParsingException("Too many arguments for keyword '"+ keyword +"' expected "+ expectedMax +" and got "+ argumentCount);
+			logger.warning("Too many arguments for keyword '" + keyword + "'; expected " + expectedMax + " and got " + argumentCount);
+//			throw new TorParsingException("Too many arguments for keyword '" + keyword + "'; expected " + expectedMax + " and got " + argumentCount);