Opened 3 weeks ago

Closed 4 days ago

#2651 closed enhancement (fixed)

ACKSender.java: do not warn of re-requests

Reported by: jogger Owned by: zzz
Priority: minor Milestone: undecided
Component: router/transport Version: 0.9.43
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

That warning is totally misleading, as packets are large enough to carry all outstanding ACKs - nothing left to re-request.

This basically warns of Java concurrency working, as seen from the recvAge, making clear the reason is a concurrently incoming packet needing to be ACKed. The requeueing is also not needed as the peer was already queued up concurrently.

Subtickets

Change History (3)

comment:1 Changed 7 days ago by zzz

Status: newinfoneeded_new

this is a proposal solely to remove the log message at line 202?

comment:2 Changed 5 days ago by jogger

Status: infoneeded_newnew

May be it would be sufficient to downgrade to INFO and state that we requeue as a precaution.

comment:3 Changed 4 days ago by zzz

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.