Opened 3 weeks ago

Last modified 7 days ago

#2653 new enhancement

ACKSender: properly set send time

Reported by: jogger Owned by: zzz
Priority: minor Milestone: undecided
Component: router/transport Version: 0.9.43
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

in retrieveACKBitfields() there is

            if (_currentACKs.isEmpty())
                _wantACKSendSince = -1;

However if we could not ACK everything, _wantACKSendSince is untouched. If we are currently piggybackACKing there is a good chance outstanding ACKs will be picked up by the next packet. In this case ACKSender could hit in between and cause an extra packet to be sent. This can be prevented by setting _wantACKSendSince to now() in this case.

Subtickets

Change History (1)

comment:1 Changed 7 days ago by zzz

At PeerState? line 1070

Note: See TracTickets for help on using tickets.