Opened 3 weeks ago

Last modified 5 days ago

#2658 new enhancement

PeerState.java: remove _slowStartThreshold

Reported by: jogger Owned by: zzz
Priority: minor Milestone: undecided
Component: router/transport Version: 0.9.43
Keywords: Cc:
Parent Tickets: Sensitive: no

Description

As it is coded now _slowStartThreshold lets the send window grow fast until the first retransmission, then drops back and subsequently allows for a single increase or none at all. So it serves no practical use and can be removed, possibly when reworking the send window.

Subtickets

Change History (2)

comment:1 Changed 7 days ago by zzz

Status: newinfoneeded_new

Already marked for removal at line 792, where it's claimed to be unused, but appears to be used at line 1210.

OP says it allows for initial fast growth, and then incremental growth, that's the canonical definition of slow start, so is it working as intended?

comment:2 Changed 5 days ago by jogger

Status: infoneeded_newnew

No, it is not. Works one time, stops working after reset at the first retrans within congestionOccurred(). Will have to come up elsewhere with a writeup why this TCP mimicking is a basic design flaw. Long story short: When we lose a packet it is most likely due to competing TCP which puts much more burden on the equipment. So behaving like TCP means losing out.

Note: See TracTickets for help on using tickets.